From 14db055d4618ccd232e04e9b35b3c3a49e3d6c3f Mon Sep 17 00:00:00 2001
From: Delan Azabani <dazabani@igalia.com>
Date: Fri, 21 Feb 2025 16:21:50 +0800
Subject: [PATCH] Fix mach argument quoting on NixOS (#35573)

This patch makes mach shell-quote its arguments when rerunning itself
with `nix-shell`, so that spaces and other special characters are
handled correctly.

Signed-off-by: Delan Azabani <dazabani@igalia.com>
---
 mach | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/mach b/mach
index 5071dfd218f..7d8fe738d36 100755
--- a/mach
+++ b/mach
@@ -15,6 +15,14 @@
     run_in_nix_if_needed() {
         if { [ -f /etc/NIXOS ] || [ -n "${MACH_USE_NIX}" ]; } && [ -z "${IN_NIX_SHELL}" ]; then
             EXTRA_NIX_ARGS=${SERVO_ANDROID_BUILD:+'--arg buildAndroid true'}
+
+            # `nix-shell` needs the whole command passed as a single argument, so the arguments need
+            # to be shell-quoted. Rotate through the arguments, replacing them with quoted versions.
+            for arg in "$@"; do
+                set -- "$@" "$(printf \%q "$1")"
+                shift
+            done
+
             echo "NOTE: Entering nix-shell ${MACH_DIR}/shell.nix"
             exec nix-shell "${MACH_DIR}/shell.nix" $EXTRA_NIX_ARGS --run "$*"
         else