Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Differentiate between HTTP and non-HTTP APIs for cookie operations. Fix some incorrect cookie removal operation logic. Order the returned cookies according to the spec. Make cookie unit tests pass.

Browse source
This commit is contained in:
Josh Matthews 2015-01-15 01:51:06 -05:00
parent 24c8896f88
commit 14df9f8a70
7 changed files with 142 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

35
components/net/image_cache_task.rs
View file

@ -555,13 +555,6 @@ mod tests {
}
fn mock_resource_task<T: Closure+Send>(on_load: Box<T>) -> ResourceTask {
let cookie_chan = spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
match port.recv() {
_ => { continue }
}
}
});
spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
match port.recv().unwrap() {
@ -572,11 +565,11 @@ mod tests {
eventual_consumer: response.consumer.clone(),
};
let chan = start_sending(senders, Metadata::default(
Url::parse("file:///fake", cookie_chan.clone()).unwrap()));
Url::parse("file:///fake").unwrap()));
on_load.invoke(chan);
}
resource_task::ControlMsg::Cookies(_) => {}
resource_task::ControlMsg::Exit => break
resource_task::ControlMsg::Exit => break,
_ => {}
}
}
})
@ -718,13 +711,6 @@ mod tests {
let (image_bin_sent_chan, image_bin_sent) = channel();
let (resource_task_exited_chan, resource_task_exited) = channel();
let cookie_chan = spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
match port.recv() {
_ => { continue }
}
}
});
let mock_resource_task = spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
@ -736,16 +722,16 @@ mod tests {
eventual_consumer: response.consumer.clone(),
};
let chan = start_sending(senders, Metadata::default(
Url::parse("file:///fake").unwrap()), cookie_chan.clone());
Url::parse("file:///fake").unwrap()));
chan.send(Payload(test_image_bin()));
chan.send(Done(Ok(())));
image_bin_sent_chan.send(());
}
resource_task::ControlMsg::Cookies(_) => {}
resource_task::ControlMsg::Exit => {
resource_task_exited_chan.send(());
break
}
_ => {}
}
}
});
@ -778,13 +764,6 @@ mod tests {
let (image_bin_sent_chan, image_bin_sent) = channel();
let (resource_task_exited_chan, resource_task_exited) = channel();
let cookie_chan = spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
match port.recv() {
_ => { continue }
}
}
});
let mock_resource_task = spawn_listener(move |port: Receiver<resource_task::ControlMsg>| {
loop {
match port.recv().unwrap() {
@ -795,16 +774,16 @@ mod tests {
eventual_consumer: response.consumer.clone(),
};
let chan = start_sending(senders, Metadata::default(
Url::parse("file:///fake").unwrap()), cookie_chan.clone());
Url::parse("file:///fake").unwrap()));
chan.send(Payload(test_image_bin()));
chan.send(Done(Err("".to_string())));
image_bin_sent_chan.send(());
}
resource_task::ControlMsg::Cookies(_) => {}
resource_task::ControlMsg::Exit => {
resource_task_exited_chan.send(());
break
}
_ => {}
}
}
});