Fix some clippy warnings in components/gfx and components/script (#32215)

* clippy: Squish warnings and errors in gfx

warning: redundant closure (gfx/font.rs:415:18)

warning: useless conversion to the same type (gfx/font.rs:534:9)

warning: the following explicit lifetimes could be elided: 'a (gfx/font.rs:619:16)

error: this loop never actually loops (gfx/font_cache_thread.rs:112:9)

warning: this expression creates a reference which is immediately dereferenced by the compiler  (gfx/font_cache_thread.rs:229:51)

warning: redundant closure (gfx/font_cache_thread.rs:551:18)

3 instances of:
warning: casting integer literal to `f64` is unnecessary (gfx/platform/freetype/font_list.rs:271-273)

* clippy: methods called `from_*` usually take no `self`

It reports that by standard convention, from_* methods should not take any `&self` parameter

* clippy: you should consider adding a `Default` implementation

It reports that public types with a pub fn new() -> Self should have a Default implementation since they can be constructed without arguments

* clippy: casting to the same type is unnecessary (`f32` -> `f32`)

* clippy: use of `unwrap_or_else` to construct default value

* clippy: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self`

* clippy: manual `!RangeInclusive::contains` implementation

contains expresses the intent better and has less failure modes (such as fencepost errors or using || instead of &&)

* clippy: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`

* clippy: Fix some new warnings

warning: this `if` statement can be collapsed (gfx/font.rs:468:130)

warning: this lifetime isn't used in the impl (gfx/platform/freetype/font.rs:341:6)

warning: field assignment outside of initializer for an instance created with Default::default() (compositor.rs:881:17)

components/script/dom/abstractworkerglobalscope.rs

@@ -91,9 +91,9 @@ pub trait WorkerEventLoopMethods {
     fn task_queue(&self) -> &TaskQueue<Self::WorkerMsg>;
     fn handle_event(&self, event: Self::Event) -> bool;
     fn handle_worker_post_event(&self, worker: &TrustedWorkerAddress) -> Option<AutoWorkerReset>;
-    fn from_control_msg(&self, msg: Self::ControlMsg) -> Self::Event;
-    fn from_worker_msg(&self, msg: Self::WorkerMsg) -> Self::Event;
-    fn from_devtools_msg(&self, msg: DevtoolScriptControlMsg) -> Self::Event;
+    fn from_control_msg(msg: Self::ControlMsg) -> Self::Event;
+    fn from_worker_msg(msg: Self::WorkerMsg) -> Self::Event;
+    fn from_devtools_msg(msg: DevtoolScriptControlMsg) -> Self::Event;
     fn control_receiver(&self) -> &Receiver<Self::ControlMsg>;
 }
 
@@ -114,13 +114,13 @@ pub fn run_worker_event_loop<T, WorkerMsg, Event>(
         .map(|_| scope.from_devtools_receiver());
     let task_queue = worker_scope.task_queue();
     let event = select! {
-        recv(worker_scope.control_receiver()) -> msg => worker_scope.from_control_msg(msg.unwrap()),
+        recv(worker_scope.control_receiver()) -> msg => T::from_control_msg(msg.unwrap()),
         recv(task_queue.select()) -> msg => {
             task_queue.take_tasks(msg.unwrap());
-            worker_scope.from_worker_msg(task_queue.recv().unwrap())
+            T::from_worker_msg(task_queue.recv().unwrap())
         },
         recv(devtools_port.unwrap_or(&crossbeam_channel::never())) -> msg =>
-            worker_scope.from_devtools_msg(msg.unwrap()),
+            T::from_devtools_msg(msg.unwrap()),
     };
     let mut sequential = vec![];
     sequential.push(event);
@@ -136,9 +136,9 @@ pub fn run_worker_event_loop<T, WorkerMsg, Event>(
             Err(_) => match devtools_port.map(|port| port.try_recv()) {
                 None => {},
                 Some(Err(_)) => break,
-                Some(Ok(ev)) => sequential.push(worker_scope.from_devtools_msg(ev)),
+                Some(Ok(ev)) => sequential.push(T::from_devtools_msg(ev)),
             },
-            Ok(ev) => sequential.push(worker_scope.from_worker_msg(ev)),
+            Ok(ev) => sequential.push(T::from_worker_msg(ev)),
         }
     }
     // Step 3