mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
Auto merge of #21583 - AgustinCB:add-task-source-name, r=jdm
Add task source name Refactor `CommonScriptMsg::Task` to include `TaskSourceName`. Sorry for the delay, between doing this after work and the time I spent trying to ramp up on the project, it took me a bit longer than I expected. Test still don't pass in local, but they fail the same way on master, so I guess it's ok. I may have forgotten something, I refactored mostly the stuff that the compiler complained about. Please let me know if I missed anything. I tried to dump my thought process on the commit messages, so feel free to go commit by commit to understand context. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21527 - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's mostly refactor, no new behavior added. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21583) <!-- Reviewable:end -->
This commit is contained in:
commit
162826d6a9
18 changed files with 134 additions and 71 deletions
|
@ -1667,7 +1667,8 @@ impl Window {
|
|||
let _ = self.script_chan.send(CommonScriptMsg::Task(
|
||||
ScriptThreadEventCategory::DomEvent,
|
||||
Box::new(self.task_canceller(TaskSourceName::DOMManipulation).wrap_task(task)),
|
||||
self.pipeline_id()
|
||||
self.pipeline_id(),
|
||||
TaskSourceName::DOMManipulation,
|
||||
));
|
||||
doc.set_url(url.clone());
|
||||
return
|
||||
|
@ -2124,7 +2125,8 @@ impl Window {
|
|||
let _ = self.script_chan.send(CommonScriptMsg::Task(
|
||||
ScriptThreadEventCategory::DomEvent,
|
||||
Box::new(self.task_canceller(TaskSourceName::DOMManipulation).wrap_task(task)),
|
||||
self.pipeline_id()
|
||||
self.pipeline_id(),
|
||||
TaskSourceName::DOMManipulation,
|
||||
));
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue