Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #26906 - gterzian:fix_streams_and_re-direct, r=Manishearth

Browse source 
Fix streaming request bodies

<!-- Please describe your changes on the following line: -->

FIX #26904

At this point I'm not sure if the hyper `Body::wrap_stream` integration by way of the IPC route is broken, or if perhaps there is a problem with the WPT server not handling the requests properly, as I am getting a bunch of:

```
 0:04.54 INFO STDERR: 127.0.0.1 - - [13/Jun/2020 18:22:08] code 400, message Bad request syntax ('4')
 0:04.54 INFO STDERR: 127.0.0.1 - - [13/Jun/2020 18:22:08] "4" 400 -
```

In any case, the `start_reading` call in `body.rs` had to be put into the other function, since it should not be called for each chunk(this was actually failing before).

I've also added the chunked header in case the source is a stream.

Last thing to figure out, why is the request data not actually reaching the server, or not being handled properly by it.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-06-16 13:01:20 -04:00 • committed by GitHub
commit 16a99daa22
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 282 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

32
tests/wpt/metadata/fetch/api/basic/request-upload.any.js.ini
View file

@ -1,41 +1,9 @@
[request-upload.any.html]
type: testharness
[Fetch with POST with ReadableStream]
expected: FAIL
[Fetch with POST with ReadableStream containing String]
expected: FAIL
[Fetch with POST with ReadableStream containing null]
expected: FAIL
[Fetch with POST with ReadableStream containing number]
expected: FAIL
[Fetch with POST with ReadableStream containing ArrayBuffer]
expected: FAIL
[Fetch with POST with ReadableStream containing Blob]
expected: FAIL
[request-upload.any.worker.html]
type: testharness
[Fetch with POST with ReadableStream]
expected: FAIL
[Fetch with POST with ReadableStream containing String]
expected: FAIL
[Fetch with POST with ReadableStream containing null]
expected: FAIL
[Fetch with POST with ReadableStream containing number]
expected: FAIL
[Fetch with POST with ReadableStream containing ArrayBuffer]
expected: FAIL
[Fetch with POST with ReadableStream containing Blob]
expected: FAIL