Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Webdriver: Keyboard Action use webview::notify_input_event instead of directly sent to constellation (#37908)

Browse source 
Previously, we KeyboardAction will be forwarded to constellation by the
embedder. Now we use `webview.notify_input_event`, which will send
`WebDriverCommandMsg::ForwardInputEvent` for KeyboardAction

Fixes: part of https://github.com/servo/servo/issues/37370

---------

Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
This commit is contained in:
Kenzie Raditya Tirtarahardja 2025-07-08 14:54:57 +08:00 • committed by GitHub
parent 11bb83d422
commit 1773ea44f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 17 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/webdriver_server/actions.rs
View file

@ -311,11 +311,8 @@ impl Handler {
// Step 12
self.increment_num_pending_actions();
let msg_id = self.current_action_id.get();
let cmd_msg = WebDriverCommandMsg::KeyboardAction(
self.session().unwrap().browsing_context_id,
keyboard_event,
msg_id,
);
let cmd_msg =
WebDriverCommandMsg::KeyboardAction(session.webview_id, keyboard_event, msg_id);
let _ = self.send_message_to_embedder(cmd_msg);
}
@ -350,11 +347,8 @@ impl Handler {
// Step 12
self.increment_num_pending_actions();
let msg_id = self.current_action_id.get();
let cmd_msg = WebDriverCommandMsg::KeyboardAction(
self.session().unwrap().browsing_context_id,
keyboard_event,
msg_id,
);
let cmd_msg =
WebDriverCommandMsg::KeyboardAction(session.webview_id, keyboard_event, msg_id);
let _ = self.send_message_to_embedder(cmd_msg);
}
}