Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 05:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #10821 - askeing:fix_10782, r=jdm

Browse source 
Checking the browsing_context before change title

fix #10782

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10821)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-05-06 14:20:45 -07:00
commit 17ba9fb5da
4 changed files with 46 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/document.rs
View file

@ -624,11 +624,13 @@ impl Document {
/// Handles any updates when the document's title has changed. /// Handles any updates when the document's title has changed.
pub fn title_changed(&self) { pub fn title_changed(&self) {
if self.browsing_context().is_some() {
// https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowsertitlechange // https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowsertitlechange
self.trigger_mozbrowser_event(MozBrowserEvent::TitleChange(String::from(self.Title()))); self.trigger_mozbrowser_event(MozBrowserEvent::TitleChange(String::from(self.Title())));
self.send_title_to_compositor(); self.send_title_to_compositor();
} }
}
/// Sends this document's title to the compositor. /// Sends this document's title to the compositor.
pub fn send_title_to_compositor(&self) { pub fn send_title_to_compositor(&self) {

6
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -6526,6 +6526,12 @@
"url": "/_mozilla/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html" "url": "/_mozilla/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html"
} }
], ],
"mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html": [
{
"path": "mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html",
"url": "/_mozilla/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html"
}
],
"mozilla/mozbrowser/redirect.html": [ "mozilla/mozbrowser/redirect.html": [
{ {
"path": "mozilla/mozbrowser/redirect.html", "path": "mozilla/mozbrowser/redirect.html",

19
tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html Normal file
View file

@ -0,0 +1,19 @@
<!doctype html>
<meta charset="utf-8">
<title>Check if title_changed is too eager (issue #10782)</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body></body>
<script>
async_test(function(t) {
var iframe = document.createElement("iframe");
iframe.mozbrowser = "true";
iframe.src = "mozbrowsertitlechangedeagerly_event_iframe.html";
iframe.addEventListener("mozbrowsertitlechange", t.step_func(e => {
assert_equals(e.type, "mozbrowsertitlechange");
assert_not_equals(e.detail, "Bar");
}));
iframe.addEventListener("load", t.step_func_done());
document.body.appendChild(iframe);
});
</script>

16
tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event_iframe.html Normal file
View file

@ -0,0 +1,16 @@
<html>
<head>
<title>Foo</title>
<script>
var text =
'<html xmlns="http://www.w3.org/1999/xhtml">' +
' <head>' +
' <title>Bar</title>' +
' </head>' +
'</html>';
var parser = new DOMParser();
var doc = parser.parseFromString(text, "text/xml");
</script>
</head>
<body>Hello world</body>
</html>