From 17dec241db16876a2cc7ae1b0e494d650e0f40ab Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Wed, 30 Aug 2023 13:43:27 +0200 Subject: [PATCH] Convert /_mozilla/css/iframe/multiple_external.html into a WPT crashtest (#30246) This test was made before the use of WPT tests, much less WPT crashtests, but it was originally made to test a crash. Initially, it had an empty result, but text was added. The new reference for the test relied on the bad float layout of legacy layout so was always incorrect. This change converts the test into a WPT crashtest. --- tests/wpt/meta/MANIFEST.json | 7 +++++++ tests/wpt/mozilla/meta/MANIFEST.json | 21 ------------------- .../tests/css/iframe/multiple_external.html | 20 ------------------ .../css/iframe/multiple_external_child.html | 5 ----- .../css/iframe/multiple_external_ref.html | 6 ------ ...iple-iframes-with-allow-scripts-crash.html | 16 ++++++++++++++ 6 files changed, 23 insertions(+), 52 deletions(-) delete mode 100644 tests/wpt/mozilla/tests/css/iframe/multiple_external.html delete mode 100644 tests/wpt/mozilla/tests/css/iframe/multiple_external_child.html delete mode 100644 tests/wpt/mozilla/tests/css/iframe/multiple_external_ref.html create mode 100644 tests/wpt/tests/html/semantics/embedded-content/the-iframe-element/multiple-iframes-with-allow-scripts-crash.html diff --git a/tests/wpt/meta/MANIFEST.json b/tests/wpt/meta/MANIFEST.json index ef8e5f6c76c..0f85b75ceaa 100644 --- a/tests/wpt/meta/MANIFEST.json +++ b/tests/wpt/meta/MANIFEST.json @@ -5574,6 +5574,13 @@ {} ] ], + "multiple-iframes-with-allow-scripts-crash.html": [ + "572f119be8e41130c62eb5a01ba4b9c8c0832080", + [ + null, + {} + ] + ], "sandbox-toggle-in-inactive-document-crash.html": [ "654542f6a8e21a23f70d50c1c547e9dac6971c36", [ diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json index bb2ee866365..a360705ea8c 100644 --- a/tests/wpt/mozilla/meta/MANIFEST.json +++ b/tests/wpt/mozilla/meta/MANIFEST.json @@ -2366,19 +2366,6 @@ {} ] ], - "multiple_external.html": [ - "c2d66f25cec3e496023755af786409fff5b3c619", - [ - null, - [ - [ - "/_mozilla/css/iframe/multiple_external_ref.html", - "==" - ] - ], - {} - ] - ], "navigation.html": [ "bbbceaea51dda8983c11d169297c11395d918077", [ @@ -8798,14 +8785,6 @@ "cb61f63d447b8df1862fbd5c01d41508183442f0", [] ], - "multiple_external_child.html": [ - "8e1b304226d46f5f470bb0f4b59f9186eb56d3ce", - [] - ], - "multiple_external_ref.html": [ - "cb06d78125970a8127708354db716f8ad5094fc0", - [] - ], "navigation_ref.html": [ "0207d0908e16bf1b6ccb2c9e76bb844e70c8d991", [] diff --git a/tests/wpt/mozilla/tests/css/iframe/multiple_external.html b/tests/wpt/mozilla/tests/css/iframe/multiple_external.html deleted file mode 100644 index c2d66f25cec..00000000000 --- a/tests/wpt/mozilla/tests/css/iframe/multiple_external.html +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - - - iframe test - - - - diff --git a/tests/wpt/mozilla/tests/css/iframe/multiple_external_child.html b/tests/wpt/mozilla/tests/css/iframe/multiple_external_child.html deleted file mode 100644 index 8e1b304226d..00000000000 --- a/tests/wpt/mozilla/tests/css/iframe/multiple_external_child.html +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/tests/wpt/mozilla/tests/css/iframe/multiple_external_ref.html b/tests/wpt/mozilla/tests/css/iframe/multiple_external_ref.html deleted file mode 100644 index cb06d781259..00000000000 --- a/tests/wpt/mozilla/tests/css/iframe/multiple_external_ref.html +++ /dev/null @@ -1,6 +0,0 @@ - - - - iframe test - - diff --git a/tests/wpt/tests/html/semantics/embedded-content/the-iframe-element/multiple-iframes-with-allow-scripts-crash.html b/tests/wpt/tests/html/semantics/embedded-content/the-iframe-element/multiple-iframes-with-allow-scripts-crash.html new file mode 100644 index 00000000000..572f119be8e --- /dev/null +++ b/tests/wpt/tests/html/semantics/embedded-content/the-iframe-element/multiple-iframes-with-allow-scripts-crash.html @@ -0,0 +1,16 @@ + + + + + + + +