From 1800da779c49b30f5b20d6e238bfe430e3377338 Mon Sep 17 00:00:00 2001 From: Connor Brewster Date: Tue, 30 May 2017 15:21:33 -0600 Subject: [PATCH] Fix custom element registry define test The test relies on DOM elements with ids beind added as properties of the window. Servo does not do this, and this is not a best practice. --- tests/wpt/metadata/MANIFEST.json | 2 +- .../custom-elements/custom-element-registry/define.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/wpt/metadata/MANIFEST.json b/tests/wpt/metadata/MANIFEST.json index 567609e2c1d..a235abdc2e5 100644 --- a/tests/wpt/metadata/MANIFEST.json +++ b/tests/wpt/metadata/MANIFEST.json @@ -554144,7 +554144,7 @@ "testharness" ], "custom-elements/custom-element-registry/define.html": [ - "724060b276a1f3254fd226e329631005ec5a5e87", + "4f3d4da1aae8efab035a4b951147904d71e7de3b", "testharness" ], "custom-elements/disconnected-callbacks.html": [ diff --git a/tests/wpt/web-platform-tests/custom-elements/custom-element-registry/define.html b/tests/wpt/web-platform-tests/custom-elements/custom-element-registry/define.html index fedb687416e..e5d71ec6eab 100644 --- a/tests/wpt/web-platform-tests/custom-elements/custom-element-registry/define.html +++ b/tests/wpt/web-platform-tests/custom-elements/custom-element-registry/define.html @@ -12,6 +12,7 @@ // https://html.spec.whatwg.org/multipage/scripting.html#element-definition // Use window from iframe to isolate the test. + const iframe = document.getElementById("iframe"); const testWindow = iframe.contentDocument.defaultView; const customElements = testWindow.customElements;