Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Mention #20534 near the enable/disable/isEnabled WebGL methods

Browse source
This commit is contained in:
Anthony Ramine 2018-04-04 17:44:17 +02:00
parent fb290e9c9e
commit 1881c09a9c
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/webglrenderingcontext.rs
View file

@ -1933,6 +1933,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
} }
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3
// FIXME: https://github.com/servo/servo/issues/20534
fn Enable(&self, cap: u32) { fn Enable(&self, cap: u32) {
if self.validate_feature_enum(cap) { if self.validate_feature_enum(cap) {
self.send_command(WebGLCommand::Enable(cap)); self.send_command(WebGLCommand::Enable(cap));
@ -1940,6 +1941,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
} }
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3
// FIXME: https://github.com/servo/servo/issues/20534
fn Disable(&self, cap: u32) { fn Disable(&self, cap: u32) {
if self.validate_feature_enum(cap) { if self.validate_feature_enum(cap) {
self.send_command(WebGLCommand::Disable(cap)); self.send_command(WebGLCommand::Disable(cap));
@ -2496,8 +2498,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
buffer.map_or(false, |buf| buf.target().is_some() && !buf.is_deleted()) buffer.map_or(false, |buf| buf.target().is_some() && !buf.is_deleted())
} }
// TODO: We could write this without IPC, recording the calls to `enable` and `disable`.
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3
// FIXME: https://github.com/servo/servo/issues/20534
fn IsEnabled(&self, cap: u32) -> bool { fn IsEnabled(&self, cap: u32) -> bool {
if self.validate_feature_enum(cap) { if self.validate_feature_enum(cap) {
let (sender, receiver) = webgl_channel().unwrap(); let (sender, receiver) = webgl_channel().unwrap();