mirror of
https://github.com/servo/servo.git
synced 2025-07-22 14:53:49 +01:00
script: Reduce the use of unsafe
in LayoutDom (#31979)
Remove the use of unsafe code in the layout wrappers of the DOM. The main change here is that `unsafe_get()` no longer needs to be an unsafe method, which allows us to transitively remove or reduce unsafe blocks from callers. The function itself is not renamed, because it's still a bit dangerous to start removing the layers of abstraction from actual DOM nodes. In addition `init_style_and_opaque_layout_data` can be merged into `initialize_data`, which removes one more unsafe method. Finally, a "Safety" section is added to some unsafe methods.
This commit is contained in:
parent
8aaff61334
commit
18b37e676b
19 changed files with 89 additions and 86 deletions
|
@ -515,15 +515,13 @@ pub trait HTMLIFrameElementLayoutMethods {
|
|||
|
||||
impl HTMLIFrameElementLayoutMethods for LayoutDom<'_, HTMLIFrameElement> {
|
||||
#[inline]
|
||||
#[allow(unsafe_code)]
|
||||
fn pipeline_id(self) -> Option<PipelineId> {
|
||||
unsafe { (self.unsafe_get()).pipeline_id.get() }
|
||||
(self.unsafe_get()).pipeline_id.get()
|
||||
}
|
||||
|
||||
#[inline]
|
||||
#[allow(unsafe_code)]
|
||||
fn browsing_context_id(self) -> Option<BrowsingContextId> {
|
||||
unsafe { (self.unsafe_get()).browsing_context_id.get() }
|
||||
(self.unsafe_get()).browsing_context_id.get()
|
||||
}
|
||||
|
||||
fn get_width(self) -> LengthOrPercentageOrAuto {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue