Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Reduce the use of unsafe in LayoutDom (#31979)

Browse source 
Remove the use of unsafe code in the layout wrappers of the DOM. The
main change here is that `unsafe_get()` no longer needs to be an unsafe
method, which allows us to transitively remove or reduce unsafe blocks
from callers. The function itself is not renamed, because it's still
a bit dangerous to start removing the layers of abstraction from actual
DOM nodes.

In addition `init_style_and_opaque_layout_data` can be merged into
`initialize_data`, which removes one more unsafe method.

Finally, a "Safety" section is added to some unsafe methods.
This commit is contained in:
Martin Robinson 2024-04-03 10:41:19 +02:00 • committed by GitHub
parent 8aaff61334
commit 18b37e676b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 89 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/script/dom/htmltableelement.rs
View file

@ -440,19 +440,16 @@ impl HTMLTableElementLayoutHelpers for LayoutDom<'_, HTMLTableElement> {
.cloned()
}
#[allow(unsafe_code)]
fn get_border(self) -> Option<u32> {
unsafe { (self.unsafe_get()).border.get() }
(self.unsafe_get()).border.get()
}
#[allow(unsafe_code)]
fn get_cellpadding(self) -> Option<u32> {
unsafe { (self.unsafe_get()).cellpadding.get() }
(self.unsafe_get()).cellpadding.get()
}
#[allow(unsafe_code)]
fn get_cellspacing(self) -> Option<u32> {
unsafe { (self.unsafe_get()).cellspacing.get() }
(self.unsafe_get()).cellspacing.get()
}
fn get_width(self) -> LengthOrPercentageOrAuto {