mirror of
https://github.com/servo/servo.git
synced 2025-08-03 20:50:07 +01:00
style: Tidy and sprinkle some comments.
This commit is contained in:
parent
3e27459ad3
commit
190e9b9715
3 changed files with 15 additions and 6 deletions
|
@ -243,6 +243,8 @@ impl ToCss for FontSettingTagInt {
|
|||
1 => Ok(()),
|
||||
0 => dest.write_str(" off"),
|
||||
x => {
|
||||
// FIXME(emilio): Why in the world does this serialize the space
|
||||
// itself?
|
||||
dest.write_char(' ')?;
|
||||
x.to_css(dest)
|
||||
}
|
||||
|
@ -252,6 +254,7 @@ impl ToCss for FontSettingTagInt {
|
|||
|
||||
impl Parse for FontSettingTagInt {
|
||||
fn parse<'i, 't>(_context: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
|
||||
// FIXME(emilio): This doesn't handle calc properly.
|
||||
if let Ok(value) = input.try(|input| input.expect_integer()) {
|
||||
// handle integer, throw if it is negative
|
||||
if value >= 0 {
|
||||
|
@ -272,9 +275,11 @@ impl Parse for FontSettingTagInt {
|
|||
}
|
||||
}
|
||||
|
||||
|
||||
impl Parse for FontSettingTagFloat {
|
||||
fn parse<'i, 't>(_: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
|
||||
// FIXME(emilio): Should handle calc() using Number::parse.
|
||||
//
|
||||
// Also why is this not in font.rs?
|
||||
input.expect_number().map(FontSettingTagFloat).map_err(|e| e.into())
|
||||
}
|
||||
}
|
||||
|
|
|
@ -2060,6 +2060,7 @@ pub enum MozScriptLevel {
|
|||
|
||||
impl Parse for MozScriptLevel {
|
||||
fn parse<'i, 't>(_: &ParserContext, input: &mut Parser<'i, 't>) -> Result<MozScriptLevel, ParseError<'i>> {
|
||||
// We don't bother to handle calc here.
|
||||
if let Ok(i) = input.try(|i| i.expect_integer()) {
|
||||
return Ok(MozScriptLevel::Relative(i))
|
||||
}
|
||||
|
|
|
@ -825,8 +825,10 @@ impl LengthOrPercentage {
|
|||
/// Parse a length, treating dimensionless numbers as pixels
|
||||
///
|
||||
/// <https://www.w3.org/TR/SVG2/types.html#presentation-attribute-css-value>
|
||||
pub fn parse_numbers_are_pixels<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
||||
-> Result<LengthOrPercentage, ParseError<'i>> {
|
||||
pub fn parse_numbers_are_pixels<'i, 't>(
|
||||
context: &ParserContext,
|
||||
input: &mut Parser<'i, 't>,
|
||||
) -> Result<LengthOrPercentage, ParseError<'i>> {
|
||||
if let Ok(lop) = input.try(|i| Self::parse(context, i)) {
|
||||
return Ok(lop)
|
||||
}
|
||||
|
@ -840,9 +842,10 @@ impl LengthOrPercentage {
|
|||
/// Parse a non-negative length, treating dimensionless numbers as pixels
|
||||
///
|
||||
/// This is nonstandard behavior used by Firefox for SVG
|
||||
pub fn parse_numbers_are_pixels_non_negative<'i, 't>(context: &ParserContext,
|
||||
input: &mut Parser<'i, 't>)
|
||||
-> Result<LengthOrPercentage, ParseError<'i>> {
|
||||
pub fn parse_numbers_are_pixels_non_negative<'i, 't>(
|
||||
context: &ParserContext,
|
||||
input: &mut Parser<'i, 't>,
|
||||
) -> Result<LengthOrPercentage, ParseError<'i>> {
|
||||
if let Ok(lop) = input.try(|i| Self::parse_non_negative(context, i)) {
|
||||
return Ok(lop)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue