Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Tidy and sprinkle some comments.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2018-01-31 22:09:53 +01:00
parent 3e27459ad3
commit 190e9b9715
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
3 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/style/values/generics/mod.rs
View file

@ -243,6 +243,8 @@ impl ToCss for FontSettingTagInt {
1 => Ok(()),
0 => dest.write_str(" off"),
x => {
// FIXME(emilio): Why in the world does this serialize the space
// itself?
dest.write_char(' ')?;
x.to_css(dest)
}
@ -252,6 +254,7 @@ impl ToCss for FontSettingTagInt {
impl Parse for FontSettingTagInt {
fn parse<'i, 't>(_context: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
// FIXME(emilio): This doesn't handle calc properly.
if let Ok(value) = input.try(|input| input.expect_integer()) {
// handle integer, throw if it is negative
if value >= 0 {
@ -272,9 +275,11 @@ impl Parse for FontSettingTagInt {
}
}
impl Parse for FontSettingTagFloat {
fn parse<'i, 't>(_: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
// FIXME(emilio): Should handle calc() using Number::parse.
//
// Also why is this not in font.rs?
input.expect_number().map(FontSettingTagFloat).map_err(|e| e.into())
}
}