Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-19 11:20:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

Combine some access to the thread local variable for script thread. (#38752)

Browse source 
This combines some access to the thread local variable for script
thread.

- We introduce a new UserInteractingScriptGuard which on drop handles
  the resetting of was_interacting to the previous value. Sometimes
throughout the code `ScriptThread::is_user_interacting` was reset to the
previous value while sometimes just set to false. This should
remove this footgun.
- This also reduces the amount of thread local access for
MutationObservers and task queue.

Testing: WPT tests should cover this.
Fixes: This addresses part of
https://github.com/servo/servo/issues/37969 but there is probably still
stuff to be done.

---------

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Narfinger 2025-09-11 11:40:32 +02:00 • committed by GitHub
parent 5de041e6ef
commit 19f70dccf6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 156 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/meta/webxr/xrDevice_requestSession_immersive_no_gesture.https.html.ini vendored Normal file
View file

@ -0,0 +1,3 @@
[xrDevice_requestSession_immersive_no_gesture.https.html]
[Requesting immersive session outside of a user gesture rejects]
expected: FAIL

3
tests/wpt/meta/webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html.ini vendored
View file

@ -1,3 +0,0 @@
[xrDevice_requestSession_requiredFeatures_unknown.https.html]
[Tests requestSession rejects for unknown requiredFeatures]
expected: FAIL