Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

webgl: Move framebuffer initialization logic to WebGL thread.

Browse source
This commit is contained in:
Josh Matthews 2018-08-24 13:43:32 -04:00
parent df8e36aa78
commit 1b08dd5232
6 changed files with 238 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

22
components/script/dom/webglframebuffer.rs
View file

@ -34,10 +34,17 @@ enum WebGLFramebufferAttachment {
impl WebGLFramebufferAttachment {
fn needs_initialization(&self) -> bool {
match *self {
WebGLFramebufferAttachment::Renderbuffer(_) => true,
WebGLFramebufferAttachment::Renderbuffer(ref r) => !r.is_initialized(),
WebGLFramebufferAttachment::Texture { .. } => false,
}
}
fn mark_initialized(&self) {
match *self {
WebGLFramebufferAttachment::Renderbuffer(ref r) => r.mark_initialized(),
WebGLFramebufferAttachment::Texture { .. } => ()
}
}
}
#[derive(Clone, JSTraceable, MallocSizeOf)]
@ -239,15 +246,14 @@ impl WebGLFramebuffer {
];
let mut clear_bits = 0;
for &(attachment, bits) in &attachments {
if attachment.borrow().as_ref().map_or(false, |att| att.needs_initialization()) {
clear_bits |= bits;
if let Some(ref att) = *attachment.borrow() {
if att.needs_initialization() {
att.mark_initialized();
clear_bits |= bits;
}
}
}
if clear_bits != 0 {
self.upcast::<WebGLObject>().context().send_command(
WebGLCommand::Clear(clear_bits)
);
}
self.upcast::<WebGLObject>().context().initialize_framebuffer(clear_bits);
self.is_initialized.set(true);
}