Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-09 23:45:35 +01:00
Code Issues Projects Releases Packages Wiki Activity

flex: handle ‘align-self: [ first | last ]? && baseline’ (#32787)

Browse source 
* flex: handle ‘align-self: baseline’

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* FIXME: css/css-flexbox/align-items-baseline-overflow-non-visible.html

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Fix baseline selection

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Fix baseline calculation with padding/border/margin

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Fix compile errors and warnings

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Implement ‘align-self: last baseline’

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Fix bug where non-baseline-aligned items affected max baseline

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Update expectations

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

* Rename method

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>

---------

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
Delan Azabani 2024-07-18 15:03:29 +08:00 • committed by GitHub
parent 34eed29037
commit 1b1f79305e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 118 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-005.html.ini vendored
View file

@ -1,6 +1,3 @@
[flex-align-baseline-005.html]
[#target > div 1]
expected: FAIL
[#target > div 3]
expected: FAIL

3
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-006.html.ini vendored
View file

@ -1,6 +1,3 @@
[flex-align-baseline-006.html]
[#target > div 1]
expected: FAIL
[#target > div 3]
expected: FAIL

3
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-007.html.ini vendored
View file

@ -1,6 +1,3 @@
[flex-align-baseline-007.html]
[#target > div 1]
expected: FAIL
[#target > div 3]
expected: FAIL

3
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-grid-001.html.ini vendored
View file

@ -11,8 +11,5 @@
[.target > * 7]
expected: FAIL
[.target > * 9]
expected: FAIL
[.target > * 11]
expected: FAIL

24
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-line-clamp-001.tentative.html.ini vendored
View file

@ -1,36 +1,12 @@
[flex-align-baseline-line-clamp-001.tentative.html]
[.target > * 1]
expected: FAIL
[.target > * 3]
expected: FAIL
[.target > * 5]
expected: FAIL
[.target > * 7]
expected: FAIL
[.target > * 9]
expected: FAIL
[.target > * 11]
expected: FAIL
[.target > * 13]
expected: FAIL
[.target > * 15]
expected: FAIL
[.target > * 17]
expected: FAIL
[.target > * 19]
expected: FAIL
[.target > * 21]
expected: FAIL
[.target > * 23]
expected: FAIL

9
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-multicol-001.html.ini vendored
View file

@ -1,18 +1,9 @@
[flex-align-baseline-multicol-001.html]
[.target > * 1]
expected: FAIL
[.target > * 3]
expected: FAIL
[.target > * 5]
expected: FAIL
[.target > * 7]
expected: FAIL
[.target > * 9]
expected: FAIL
[.target > * 11]
expected: FAIL

6
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-overflow-001.html.ini vendored
View file

@ -1,10 +1,4 @@
[flex-align-baseline-overflow-001.html]
[.target > * 1]
expected: FAIL
[.target > * 3]
expected: FAIL
[.target > * 6]
expected: FAIL

6
tests/wpt/meta/css/css-flexbox/alignment/flex-align-baseline-table-001.html.ini vendored
View file

@ -1,10 +1,4 @@
[flex-align-baseline-table-001.html]
[.target > * 1]
expected: FAIL
[.target > * 3]
expected: FAIL
[.target > * 5]
expected: FAIL