Mark @@iterator as nonenumerable

components/script/dom/bindings/codegen/CodegenRust.py

@@ -1633,6 +1633,7 @@ class MethodDefiner(PropertyDefiner):
         self.regular = [{"name": m.identifier.name,
                          "methodInfo": not m.isStatic(),
                          "length": methodLength(m),
+                         "flags": "JSPROP_ENUMERATE",
                          "condition": PropertyDefiner.getControllingCondition(m, descriptor)}
                         for m in methods]
 
@@ -1642,6 +1643,7 @@ class MethodDefiner(PropertyDefiner):
                                  "methodInfo": False,
                                  "selfHostedName": "ArrayValues",
                                  "length": 0,
+                                 "flags": "0",  # Not enumerable, per spec.
                                  "condition": "Condition::Satisfied"})
 
         # Generate the keys/values/entries aliases for value iterables.
@@ -1656,6 +1658,7 @@ class MethodDefiner(PropertyDefiner):
                 "methodInfo": False,
                 "selfHostedName": "ArrayKeys",
                 "length": 0,
+                "flags": "JSPROP_ENUMERATE",
                 "condition": PropertyDefiner.getControllingCondition(m,
                                                                      descriptor)
             })
@@ -1664,6 +1667,7 @@ class MethodDefiner(PropertyDefiner):
                 "methodInfo": False,
                 "selfHostedName": "ArrayValues",
                 "length": 0,
+                "flags": "JSPROP_ENUMERATE",
                 "condition": PropertyDefiner.getControllingCondition(m,
                                                                      descriptor)
             })
@@ -1672,6 +1676,7 @@ class MethodDefiner(PropertyDefiner):
                 "methodInfo": False,
                 "selfHostedName": "ArrayEntries",
                 "length": 0,
+                "flags": "JSPROP_ENUMERATE",
                 "condition": PropertyDefiner.getControllingCondition(m,
                                                                      descriptor)
             })
@@ -1680,6 +1685,7 @@ class MethodDefiner(PropertyDefiner):
                 "methodInfo": False,
                 "selfHostedName": "ArrayForEach",
                 "length": 1,
+                "flags": "JSPROP_ENUMERATE",
                 "condition": PropertyDefiner.getControllingCondition(m,
                                                                      descriptor)
             })
@@ -1692,6 +1698,7 @@ class MethodDefiner(PropertyDefiner):
                     "name": "toString",
                     "nativeName": stringifier.identifier.name,
                     "length": 0,
+                    "flags": "JSPROP_ENUMERATE",
                     "condition": PropertyDefiner.getControllingCondition(stringifier, descriptor)
                 })
         self.unforgeable = unforgeable
@@ -1703,13 +1710,10 @@ class MethodDefiner(PropertyDefiner):
         def condition(m, d):
             return m["condition"]
 
-        flags = "JSPROP_ENUMERATE"
+        def specData(m):
+            flags = m["flags"]
             if self.unforgeable:
                 flags += " | JSPROP_PERMANENT | JSPROP_READONLY"
-
-        def specData(m):
-            # TODO: Use something like JS_FNSPEC
-            # https://github.com/servo/servo/issues/6391
             if "selfHostedName" in m:
                 selfHostedName = '%s as *const u8 as *const libc::c_char' % str_to_const_array(m["selfHostedName"])
                 assert not m.get("methodInfo", True)
@@ -3071,12 +3075,14 @@ assert!((*cache)[PrototypeList::Constructor::%(id)s as usize].is_null());
                                                    symbolJSID=symbolJSID))
                     defineFn = "JS_DefinePropertyById2"
                     prop = "iteratorId.handle()"
+                    enumFlags = "0"  # Not enumerable, per spec.
                 elif alias.startswith("@@"):
                     raise TypeError("Can't handle any well-known Symbol other than @@iterator")
                 else:
                     getSymbolJSID = None
                     defineFn = "JS_DefineProperty"
                     prop = '"%s"' % alias
+                    enumFlags = "JSPROP_ENUMERATE"
                 return CGList([
                     getSymbolJSID,
                     # XXX If we ever create non-enumerable properties that can
@@ -3085,10 +3091,11 @@ assert!((*cache)[PrototypeList::Constructor::%(id)s as usize].is_null());
                     CGGeneric(fill(
                         """
                         assert!(${defineFn}(*cx, prototype.handle(), ${prop}, aliasedVal.handle(),
-                                            JSPROP_ENUMERATE as u32));
+                                            ${enumFlags} as u32));
                         """,
                         defineFn=defineFn,
-                        prop=prop))
+                        prop=prop,
+                        enumFlags=enumFlags))
                 ], "\n")
 
             def defineAliasesFor(m):

tests/wpt/metadata/dom/idlharness.window.js.ini

@@ -229,9 +229,6 @@
   [AbortSignal interface: existence and properties of interface prototype object's @@unscopables property]
     expected: FAIL
 
-  [DOMTokenList interface: iterable<DOMString>]
-    expected: FAIL
-
   [Document interface: existence and properties of interface prototype object's @@unscopables property]
     expected: FAIL
 
@@ -487,9 +484,6 @@
   [AbstractRange interface: attribute endOffset]
     expected: FAIL
 
-  [NodeList interface: iterable<Node>]
-    expected: FAIL
-
   [CharacterData interface: operation before([object Object\],[object Object\])]
     expected: FAIL
 

tests/wpt/metadata/fetch/api/idlharness.any.js.ini

@@ -64,9 +64,6 @@
   [Request interface: new Request('about:blank') must inherit property "isReloadNavigation" with the proper type]
     expected: FAIL
 
-  [Headers interface: iterable<ByteString, ByteString>]
-    expected: FAIL
-
   [Request interface: new Request('about:blank') must inherit property "signal" with the proper type]
     expected: FAIL
 
@@ -147,9 +144,6 @@
   [Request interface: new Request('about:blank') must inherit property "isReloadNavigation" with the proper type]
     expected: FAIL
 
-  [Headers interface: iterable<ByteString, ByteString>]
-    expected: FAIL
-
   [Request interface: new Request('about:blank') must inherit property "signal" with the proper type]
     expected: FAIL
 

tests/wpt/metadata/url/idlharness.any.js.ini

@@ -8,9 +8,6 @@
   [URL interface: legacy window alias]
     expected: FAIL
 
-  [URLSearchParams interface: iterable<USVString, USVString>]
-    expected: FAIL
-
 
 [idlharness.any.worker.html]
   [idlharness]
@@ -19,6 +16,3 @@
   [Testing Symbol.iterator property of iterable interface URLSearchParams]
     expected: FAIL
 
-  [URLSearchParams interface: iterable<USVString, USVString>]
-    expected: FAIL
-

tests/wpt/metadata/xhr/idlharness.any.js.ini

@@ -1,26 +1,4 @@
-[idlharness.any.html]
-  [idlharness]
-    expected: FAIL
-
-  [Testing Symbol.iterator property of iterable interface FormData]
-    expected: FAIL
-
-  [FormData interface: iterable<USVString, FormDataEntryValue>]
-    expected: FAIL
-
-
 [idlharness.any.sharedworker.html]
   [idlharness]
     expected: FAIL
 
-
-[idlharness.any.worker.html]
-  [idlharness]
-    expected: FAIL
-
-  [Testing Symbol.iterator property of iterable interface FormData]
-    expected: FAIL
-
-  [FormData interface: iterable<USVString, FormDataEntryValue>]
-    expected: FAIL
-