mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
Auto merge of #18195 - hiikezoe:disable-style-cache-for-animations, r=bholley,birtles
Don't cache style data if the element has running animations. <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1379203 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18195) <!-- Reviewable:end -->
This commit is contained in:
commit
1c9c0334ba
1 changed files with 17 additions and 0 deletions
|
@ -509,6 +509,23 @@ impl<E: TElement> StyleSharingCandidateCache<E> {
|
|||
return;
|
||||
}
|
||||
|
||||
// If the element has running animations, we can't share style.
|
||||
//
|
||||
// This is distinct from the specifies_{animations,transitions} check below,
|
||||
// because:
|
||||
// * Animations can be triggered directly via the Web Animations API.
|
||||
// * Our computed style can still be affected by animations after we no
|
||||
// longer match any animation rules, since removing animations involves
|
||||
// a sequential task and an additional traversal.
|
||||
if element.has_animations() {
|
||||
debug!("Failing to insert to the cache: running animations");
|
||||
return;
|
||||
}
|
||||
|
||||
// In addition to the above running animations check, we also need to
|
||||
// check CSS animation and transition styles since it's possible that
|
||||
// we are about to create CSS animations/transitions.
|
||||
//
|
||||
// These are things we don't check in the candidate match because they
|
||||
// are either uncommon or expensive.
|
||||
let box_style = style.get_box();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue