Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

style: Use a SmallVec for common ancestors in the bloom filter.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2017-05-19 04:59:51 +02:00
parent 05a26a2996
commit 1cea4e7942
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/style/bloom.rs
View file

@ -9,6 +9,7 @@
use dom::{SendElement, TElement}; use dom::{SendElement, TElement};
use selectors::bloom::BloomFilter; use selectors::bloom::BloomFilter;
use smallvec::SmallVec;
/// A struct that allows us to fast-reject deep descendant selectors avoiding /// A struct that allows us to fast-reject deep descendant selectors avoiding
/// selector-matching. /// selector-matching.
@ -223,7 +224,7 @@ impl<E: TElement> StyleBloom<E> {
// Let's collect the parents we are going to need to insert once we've // Let's collect the parents we are going to need to insert once we've
// found the common one. // found the common one.
let mut parents_to_insert = vec![]; let mut parents_to_insert = SmallVec::<[E; 8]>::new();
// If the bloom filter still doesn't have enough elements, the common // If the bloom filter still doesn't have enough elements, the common
// parent is up in the dom. // parent is up in the dom.
@ -245,10 +246,12 @@ impl<E: TElement> StyleBloom<E> {
// Not-so-happy case: Parent's don't match, so we need to keep going up // Not-so-happy case: Parent's don't match, so we need to keep going up
// until we find a common ancestor. // until we find a common ancestor.
// //
// Gecko currently models native anonymous content that conceptually hangs // Gecko currently models native anonymous content that conceptually
// off the document (such as scrollbars) as a separate subtree from the // hangs off the document (such as scrollbars) as a separate subtree
// document root. Thus it's possible with Gecko that we do not find any // from the document root.
// common ancestor. //
// Thus it's possible with Gecko that we do not find any common
// ancestor.
while **self.elements.last().unwrap() != common_parent { while **self.elements.last().unwrap() != common_parent {
parents_to_insert.push(common_parent); parents_to_insert.push(common_parent);
self.pop().unwrap(); self.pop().unwrap();