Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-15 02:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Enable rendering of conical-gradient and repeating-conical-gradient (#31597)

Browse source 
This also ignores a clippy warning for a new function (and a similar
existing one), until this code can be refactored to use temporary Rust
strutures to carry display list building state.

There are a few new test failures here:

 - FAIL [expected PASS] /css/css-images/image-set/image-set-conic-gradient-rendering.html
 - FAIL [expected PASS] /css/css-images/image-set/image-set-repeating-conic-gradient-rendering.html

 These fail because Servo does not yet support `image-set()`.

 - FAIL [expected PASS] /css/filter-effects/filter-function/filter-function-conic-gradient.html
 - FAIL [expected PASS] /css/filter-effects/filter-function/filter-function-repeating-conic-gradient.html

 These fail because Servo does not support the very early filter effects
 specification.

 - FAIL [expected PASS] /html/canvas/element/manual/fill-and-stroke-styles/conic-gradient-rotation.html
 - FAIL [expected PASS] /html/canvas/element/manual/fill-and-stroke-styles/conic-gradient.html

 These fail because this change only adds support for CSS conical
 gradients. Another set of changes will be necessary to support this for
 Canvas.
This commit is contained in:
Martin Robinson 2024-03-11 13:58:44 +01:00 • committed by GitHub
parent de7b9bed85
commit 1d1f239ecc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
32 changed files with 161 additions and 405 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/wpt/meta/css/css-images/parsing/gradient-interpolation-method-valid.html.ini
View file

@ -1943,18 +1943,6 @@
[e.style['background-image'\] = "radial-gradient(in oklch decreasing hue at right center, color(srgb 1 0 0), blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(from 30deg, red, blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(at left 10px top 50em, red, blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(from 30deg, color(srgb 1 0 0), blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(at left 10px top 50em, color(srgb 1 0 0), blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(in lab, red, blue)" should set the property value]
expected: FAIL
@ -3737,12 +3725,6 @@
[e.style['background-image'\] = "radial-gradient(in oklch decreasing hue at right center, red, 50%, blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(from 30deg, red, 50%, blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(at left 10px top 50em, red, 50%, blue)" should set the property value]
expected: FAIL
[e.style['background-image'\] = "conic-gradient(in lab, red, 50%, blue)" should set the property value]
expected: FAIL