Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 22:45:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

gfx: Update Azure and Skia, and rewrite broken clipping logic.

Browse source 
This exposed some problems in our clipping logic, which was never
properly rewritten for the stacking context reform. The clipping code
worked in terms of a stack of clips, but the new stacking context code
has no concept of a stack of clip regions. Fixing that in turn exposed
some flaky/incorrect tests:

* `borders` had an incorrect reference image, as far as I can tell.

* `negative_margins` had some stray pixels, fixed by changing the text.
This commit is contained in:
Patrick Walton 2014-12-05 03:55:39 -08:00
parent 368d6dc6bf
commit 1d845ee4f2
7 changed files with 71 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

BIN
tests/ref/borders.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 2 KiB

After

Width:  |  Height:  |  Size: 8 KiB

Before After
Before After

5
tests/ref/negative_margins_a.html
View file

@ -1,7 +1,6 @@
<!DOCTYPE html>
<html>
<head>
<title>You see here a scroll labeled JUYED AWK YACC.</title>
<style>
* {
line-height: 14px;
@ -12,8 +11,8 @@
</style>
</head>
<body>
<div id=a>Here lies the body of Jonathan Blake.</div>
<div id=b>Stepped on the gas instead of the brake.</div>
<div id=a>X</div>
<div id=b>X</div>
</body>
</html>

5
tests/ref/negative_margins_b.html
View file

@ -1,7 +1,6 @@
<!DOCTYPE html>
<html>
<head>
<title>You see here a scroll labeled JUYED AWK YACC.</title>
<style>
* {
line-height: 14px;
@ -18,8 +17,8 @@
</style>
</head>
<body>
<div id=a>Here lies the body of Jonathan Blake.
<div id=b>Stepped on the gas instead of the brake.</div></div>
<div id=a>X
<div id=b>X</div></div>
</body>
</html>