Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Clone node on a shadow root should always throw an error (#34742)

Browse source 
* Corrected Node-prototype-cloneNode clone part test

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>

* Corrected node code

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>

* updated MANIFEST

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>

* removed fails expectations

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>

* Removed not legacy ini file

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>

---------

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>
This commit is contained in:
Domenico Rizzo 2024-12-24 17:04:04 +01:00 • committed by GitHub
parent 6bd6d3bc86
commit 1dfb44d7b8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 3 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/node.rs
View file

@ -2946,7 +2946,7 @@ impl NodeMethods<crate::DomTypeHolder> for Node {
/// <https://dom.spec.whatwg.org/#dom-node-clonenode> /// <https://dom.spec.whatwg.org/#dom-node-clonenode>
fn CloneNode(&self, deep: bool, can_gc: CanGc) -> Fallible<DomRoot<Node>> { fn CloneNode(&self, deep: bool, can_gc: CanGc) -> Fallible<DomRoot<Node>> {
if deep && self.is::<ShadowRoot>() { if self.is::<ShadowRoot>() {
return Err(Error::NotSupported); return Err(Error::NotSupported);
} }
Ok(Node::clone( Ok(Node::clone(

3
tests/wpt/meta-legacy-layout/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-010.html.ini vendored
View file

@ -1,3 +0,0 @@
[test-010.html]
[A_10_01_02_09_T01]
expected: FAIL

2
tests/wpt/meta/MANIFEST.json vendored
View file

@ -765700,7 +765700,7 @@
] ]
], ],
"Node-prototype-cloneNode.html": [ "Node-prototype-cloneNode.html": [
"0ee47d492e5ad0ec8c00d15d4897c19772c9651d", "2f2a1110fc75a8eb199f9b1ae12e5f8d6377f08d",
[ [
null, null,
{} {}

6
tests/wpt/meta/shadow-dom/Node-prototype-cloneNode.html.ini vendored
View file

@ -1,6 +0,0 @@
[Node-prototype-cloneNode.html]
[cloneNode on a shadow root in open mode must throw a NotSupportedError]
expected: FAIL
[cloneNode on a shadow root in closed mode must throw a NotSupportedError]
expected: FAIL

3
tests/wpt/meta/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-010.html.ini vendored
View file

@ -1,3 +0,0 @@
[test-010.html]
[A_10_01_02_09_T01]
expected: FAIL

2
tests/wpt/tests/shadow-dom/Node-prototype-cloneNode.html vendored
View file

@ -23,7 +23,7 @@ function testCloneNode(mode) {
assert_throws_dom('NotSupportedError', function () { assert_throws_dom('NotSupportedError', function () {
var element = document.createElement('div'); var element = document.createElement('div');
var shadowRoot = element.attachShadow({mode: mode}); var shadowRoot = element.attachShadow({mode: mode});
shadowRoot.cloneNode(false); shadowRoot.cloneNode(true);
}, 'cloneNode(true) on a closed shadow root must throw a NotSupportedError'); }, 'cloneNode(true) on a closed shadow root must throw a NotSupportedError');
}, 'cloneNode on a shadow root in ' + mode + ' mode must throw a NotSupportedError'); }, 'cloneNode on a shadow root in ' + mode + ' mode must throw a NotSupportedError');