Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Script: Change the rest of script to not rely on Deref<str> for DOMString (#39481)

Browse source 
This is part of the future work of implementing LazyDOMString as
outlined in issue #39479.

We use str() method or direct implementations on DOMString for these
methods. We also change some types.
This is independent of https://github.com/servo/servo/pull/39480

Signed-off-by: Narfinger Narfinger@users.noreply.github.com

Testing: This is essentially just renaming a method and a type and
should not change functionality.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This commit is contained in:
Narfinger 2025-09-25 14:27:42 +02:00 • committed by GitHub
parent 9713bb9e1b
commit 1e471b9b41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
50 changed files with 219 additions and 132 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/timers.rs
View file

@ -465,7 +465,7 @@ impl JsTimers {
// If this throws an exception, catch it, report it for global, and abort these steps.
if global
.get_csp_list()
.is_js_evaluation_allowed(global, code_str.as_ref())
.is_js_evaluation_allowed(global, code_str.str())
{
// Step 9.6.2. Assert: handler is a string.
InternalTimerCallback::StringTimerCallback(code_str)
@ -611,7 +611,7 @@ impl JsTimerTask {
//
// FIXME(cybai): Use base url properly by saving private reference for timers (#27260)
_ = global.evaluate_js_on_global_with_result(
code_str,
code_str.str(),
rval.handle_mut(),
ScriptFetchOptions::default_classic_script(&global),
// Step 9.6. Let base URL be settings object's API base URL.