Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-03 18:19:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #22348 - germangb:html_media_ended, r=ferjm

Browse source 
Implement Ended media attribute

<!-- Please describe your changes on the following line: -->

This PR should implement:
* New method `HTMLMediaElement::earliest_possible_position()` for the [earliest possible position](https://html.spec.whatwg.org/multipage/media.html#earliest-possible-position)
* `Ended` attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback
* Queue steps for when the playback position reaches the end

This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged)
- #22321 (Define the Loop attribute)
- #22293 (To identify playback direction. Either forwards or backwards)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #22294.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22348)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-01-14 06:35:45 -05:00 • committed by GitHub
commit 1f9b134794
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 104 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/wpt/metadata/html/dom/interfaces.https.html.ini
View file

@ -1052,9 +1052,6 @@
[HTMLMediaElement interface: document.createElement("video") must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("video") must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("video") must inherit property "loop" with the proper type]
expected: FAIL
@ -1124,9 +1121,6 @@
[HTMLMediaElement interface: document.createElement("audio") must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("audio") must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("audio") must inherit property "loop" with the proper type]
expected: FAIL
@ -1259,9 +1253,6 @@
[HTMLMediaElement interface: new Audio() must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: new Audio() must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: new Audio() must inherit property "autoplay" with the proper type]
expected: FAIL
@ -1412,9 +1403,6 @@
[HTMLMediaElement interface: attribute seekable]
expected: FAIL
[HTMLMediaElement interface: attribute ended]
expected: FAIL
[HTMLMediaElement interface: attribute loop]
expected: FAIL
@ -6792,9 +6780,6 @@
[HTMLMediaElement interface: document.createElement("video") must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("video") must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("video") must inherit property "loop" with the proper type]
expected: FAIL
@ -6828,9 +6813,6 @@
[HTMLMediaElement interface: document.createElement("audio") must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("audio") must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: document.createElement("audio") must inherit property "loop" with the proper type]
expected: FAIL
@ -6864,9 +6846,6 @@
[HTMLMediaElement interface: new Audio() must inherit property "seekable" with the proper type]
expected: FAIL
[HTMLMediaElement interface: new Audio() must inherit property "ended" with the proper type]
expected: FAIL
[HTMLMediaElement interface: new Audio() must inherit property "loop" with the proper type]
expected: FAIL
@ -6897,9 +6876,6 @@
[HTMLMediaElement interface: attribute seekable]
expected: FAIL
[HTMLMediaElement interface: attribute ended]
expected: FAIL
[HTMLMediaElement interface: attribute loop]
expected: FAIL