From c20c4688147927124160c61befc1362d9e7612e5 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Fri, 28 Feb 2020 14:42:29 +0100 Subject: [PATCH] Rename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to_hoisted This method doesn't actually do any layout, but converts this block to a HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with its containing block later. This makes the code a little easier to read. --- components/layout_2020/flow/inline.rs | 2 +- components/layout_2020/flow/mod.rs | 2 +- components/layout_2020/positioned.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/components/layout_2020/flow/inline.rs b/components/layout_2020/flow/inline.rs index bab919f38c9..a33e5d8932a 100644 --- a/components/layout_2020/flow/inline.rs +++ b/components/layout_2020/flow/inline.rs @@ -255,7 +255,7 @@ impl InlineFormattingContext { }, }; ifc.positioning_context - .push(box_.layout(initial_start_corner, tree_rank)); + .push(box_.to_hoisted(initial_start_corner, tree_rank)); }, InlineLevelBox::OutOfFlowFloatBox(_box_) => { // TODO diff --git a/components/layout_2020/flow/mod.rs b/components/layout_2020/flow/mod.rs index 39f57bf4402..d6ab15071f6 100644 --- a/components/layout_2020/flow/mod.rs +++ b/components/layout_2020/flow/mod.rs @@ -320,7 +320,7 @@ impl BlockLevelBox { )) }, BlockLevelBox::OutOfFlowAbsolutelyPositionedBox(box_) => { - positioning_context.push(box_.layout(Vec2::zero(), tree_rank)); + positioning_context.push(box_.to_hoisted(Vec2::zero(), tree_rank)); Fragment::Anonymous(AnonymousFragment::no_op( containing_block.style.writing_mode, )) diff --git a/components/layout_2020/positioned.rs b/components/layout_2020/positioned.rs index ef561a05692..3747b4661b5 100644 --- a/components/layout_2020/positioned.rs +++ b/components/layout_2020/positioned.rs @@ -86,7 +86,7 @@ impl AbsolutelyPositionedBox { } } - pub(crate) fn layout( + pub(crate) fn to_hoisted( &self, initial_start_corner: Vec2, tree_rank: usize,