Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Final tweaks: use expect and remove unnecessary crate attributes

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2019-07-04 10:22:57 +02:00
parent 63920da347
commit 208473cdbc
5 changed files with 37 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Cargo.lock generated
View file

@ -2725,8 +2725,8 @@ dependencies = [
"serde 1.0.80 (registry+https://github.com/rust-lang/crates.io-index)", "serde 1.0.80 (registry+https://github.com/rust-lang/crates.io-index)",
"servo-media 0.1.0 (git+https://github.com/servo/media)", "servo-media 0.1.0 (git+https://github.com/servo/media)",
"servo_config 0.0.1", "servo_config 0.0.1",
"webrender 0.60.0 (git+https://github.com/servo/webrender)", "webrender 0.60.0 (git+https://github.com/jdm/webrender?branch=servo-hl)",
"webrender_api 0.60.0 (git+https://github.com/servo/webrender)", "webrender_api 0.60.0 (git+https://github.com/jdm/webrender?branch=servo-hl)",
"webrender_traits 0.0.1", "webrender_traits 0.0.1",
] ]
@ -5407,8 +5407,8 @@ name = "webrender_traits"
version = "0.0.1" version = "0.0.1"
dependencies = [ dependencies = [
"euclid 0.19.8 (registry+https://github.com/rust-lang/crates.io-index)", "euclid 0.19.8 (registry+https://github.com/rust-lang/crates.io-index)",
"webrender 0.60.0 (git+https://github.com/servo/webrender)", "webrender 0.60.0 (git+https://github.com/jdm/webrender?branch=servo-hl)",
"webrender_api 0.60.0 (git+https://github.com/servo/webrender)", "webrender_api 0.60.0 (git+https://github.com/jdm/webrender?branch=servo-hl)",
] ]
[[package]] [[package]]

2
components/media/lib.rs
View file

@ -2,8 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this * License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
#![crate_name = "media"]
#![crate_type = "rlib"]
#![deny(unsafe_code)] #![deny(unsafe_code)]
#[macro_use] #[macro_use]

40
components/webrender_traits/lib.rs
View file

@ -2,8 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this * License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
#![crate_name = "webrender_traits"]
#![crate_type = "rlib"]
#![deny(unsafe_code)] #![deny(unsafe_code)]
use euclid::Size2D; use euclid::Size2D;
@ -110,30 +108,23 @@ impl webrender::ExternalImageHandler for WebrenderExternalImageHandlers {
_channel_index: u8, _channel_index: u8,
_rendering: webrender_api::ImageRendering, _rendering: webrender_api::ImageRendering,
) -> webrender::ExternalImage { ) -> webrender::ExternalImage {
if let Some(handler_type) = self.external_images.lock().unwrap().get(&key) { let external_images = self.external_images.lock().unwrap();
let handler_type = external_images
.get(&key)
.expect("Tried to get unknown external image");
let (texture_id, uv) = match handler_type { let (texture_id, uv) = match handler_type {
WebrenderImageHandlerType::WebGL => { WebrenderImageHandlerType::WebGL => {
let (texture_id, size) = self.webgl_handler.as_mut().unwrap().lock(key.0); let (texture_id, size) = self.webgl_handler.as_mut().unwrap().lock(key.0);
( (
texture_id, texture_id,
webrender_api::TexelRect::new( webrender_api::TexelRect::new(0.0, size.height as f32, size.width as f32, 0.0),
0.0,
size.height as f32,
size.width as f32,
0.0,
),
) )
}, },
WebrenderImageHandlerType::Media => { WebrenderImageHandlerType::Media => {
let (texture_id, size) = self.media_handler.as_mut().unwrap().lock(key.0); let (texture_id, size) = self.media_handler.as_mut().unwrap().lock(key.0);
( (
texture_id, texture_id,
webrender_api::TexelRect::new( webrender_api::TexelRect::new(0.0, 0.0, size.width as f32, size.height as f32),
0.0,
0.0,
size.width as f32,
size.height as f32,
),
) )
}, },
}; };
@ -141,25 +132,18 @@ impl webrender::ExternalImageHandler for WebrenderExternalImageHandlers {
uv, uv,
source: webrender::ExternalImageSource::NativeTexture(texture_id), source: webrender::ExternalImageSource::NativeTexture(texture_id),
} }
} else {
unreachable!()
}
} }
/// Unlock the external image. The WR should not read the image /// Unlock the external image. The WR should not read the image
/// content after this call. /// content after this call.
fn unlock(&mut self, key: webrender_api::ExternalImageId, _channel_index: u8) { fn unlock(&mut self, key: webrender_api::ExternalImageId, _channel_index: u8) {
if let Some(handler_type) = self.external_images.lock().unwrap().get(&key) { let external_images = self.external_images.lock().unwrap();
let handler_type = external_images
.get(&key)
.expect("Tried to get unknown external image");
match handler_type { match handler_type {
WebrenderImageHandlerType::WebGL => { WebrenderImageHandlerType::WebGL => self.webgl_handler.as_mut().unwrap().unlock(key.0),
self.webgl_handler.as_mut().unwrap().unlock(key.0) WebrenderImageHandlerType::Media => self.media_handler.as_mut().unwrap().unlock(key.0),
},
WebrenderImageHandlerType::Media => {
self.media_handler.as_mut().unwrap().unlock(key.0)
},
}; };
} else {
unreachable!();
}
} }
} }