mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
Address review comments
This commit is contained in:
parent
5be15e55db
commit
209255b20a
6 changed files with 66 additions and 31 deletions
|
@ -33,6 +33,8 @@
|
|||
</%call>
|
||||
</%def>
|
||||
|
||||
// FIXME (Manishearth): Add computed_value_as_specified argument
|
||||
// and handle the empty case correctly
|
||||
<%doc>
|
||||
To be used in cases where we have a grammar like
|
||||
"<thing> [ , <thing> ]*", but only support a single value
|
||||
|
@ -54,13 +56,14 @@
|
|||
}
|
||||
pub mod computed_value {
|
||||
use super::single_value;
|
||||
#[derive(Debug, Clone, PartialEq, HeapSizeOf)]
|
||||
#[derive(Debug, Clone, PartialEq)]
|
||||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
||||
pub struct T(pub Vec<single_value::computed_value::T>);
|
||||
}
|
||||
|
||||
impl ToCss for computed_value::T {
|
||||
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
|
||||
if self.0.len() >= 1 {
|
||||
if !self.0.is_empty() {
|
||||
try!(self.0[0].to_css(dest));
|
||||
}
|
||||
for i in self.0.iter().skip(1) {
|
||||
|
@ -71,12 +74,13 @@
|
|||
}
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, PartialEq, HeapSizeOf)]
|
||||
#[derive(Debug, Clone, PartialEq)]
|
||||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
||||
pub struct SpecifiedValue(pub Vec<single_value::SpecifiedValue>);
|
||||
|
||||
impl ToCss for SpecifiedValue {
|
||||
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
|
||||
if self.0.len() >= 1 {
|
||||
if !self.0.is_empty() {
|
||||
try!(self.0[0].to_css(dest))
|
||||
}
|
||||
for i in self.0.iter().skip(1) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue