Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Added error checking on XMLHttpRequest::setWithCredentials

Browse source
This commit is contained in:
Keith Yeung 2015-01-31 20:41:34 +08:00
parent 2010fbf0dd
commit 2093291539
4 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/webidls/XMLHttpRequest.webidl
View file

@ -50,6 +50,7 @@ interface XMLHttpRequest : XMLHttpRequestEventTarget {
void setRequestHeader(ByteString name, ByteString value);
[SetterThrows]
attribute unsigned long timeout;
[SetterThrows]
attribute boolean withCredentials;
readonly attribute XMLHttpRequestUpload upload;
[Throws]

17
components/script/dom/xmlhttprequest.rs
View file

@ -489,8 +489,21 @@ impl<'a> XMLHttpRequestMethods for JSRef<'a, XMLHttpRequest> {
fn WithCredentials(self) -> bool {
self.with_credentials.get()
}
fn SetWithCredentials(self, with_credentials: bool) {
self.with_credentials.set(with_credentials);
// Spec for SetWithCredentials: https://xhr.spec.whatwg.org/#dom-xmlhttprequest-withcredentials
fn SetWithCredentials(self, with_credentials: bool) -> ErrorResult {
match self.ready_state.get() {
XMLHttpRequestState::HeadersReceived |
XMLHttpRequestState::Loading |
XMLHttpRequestState::XHRDone => Err(InvalidState),
_ if self.send_flag.get() => Err(InvalidState),
_ => match self.global.root() {
GlobalRoot::Window(_) if self.sync.get() => Err(InvalidAccess),
_ => {
self.with_credentials.set(with_credentials);
Ok(())
},
},
}
}
fn Upload(self) -> Temporary<XMLHttpRequestUpload> {
Temporary::new(self.upload)

8
tests/wpt/metadata/XMLHttpRequest/XMLHttpRequest-withCredentials.html.ini
View file

@ -1,8 +0,0 @@
[XMLHttpRequest-withCredentials.html]
type: testharness
[setting on synchronous XHR]
expected: FAIL
[setting withCredentials when not in UNSENT, OPENED state]
expected: FAIL

5
tests/wpt/metadata/XMLHttpRequest/XMLHttpRequest-withCredentials.worker.ini
View file

@ -1,5 +0,0 @@
[XMLHttpRequest-withCredentials.worker]
type: testharness
[setting withCredentials when not in UNSENT, OPENED state]
expected: FAIL