From 2254a9e923e9eb425eb66258d448150f6dbf4f63 Mon Sep 17 00:00:00 2001 From: Adrien Bustany Date: Tue, 4 Feb 2014 11:43:41 +0100 Subject: [PATCH] script: Pass the correct parent node to pre_insert in insertBefore Closes #1572. --- src/components/script/dom/bindings/codegen/Bindings.conf | 1 + src/components/script/dom/node.rs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/script/dom/bindings/codegen/Bindings.conf b/src/components/script/dom/bindings/codegen/Bindings.conf index 98d6ef23dd3..03ebf2a0d35 100644 --- a/src/components/script/dom/bindings/codegen/Bindings.conf +++ b/src/components/script/dom/bindings/codegen/Bindings.conf @@ -316,6 +316,7 @@ DOMInterfaces = { 'pointerType': '', 'needsAbstract': [ 'appendChild', + 'insertBefore', 'replaceChild', 'nodeName', 'nodeValue', diff --git a/src/components/script/dom/node.rs b/src/components/script/dom/node.rs index c1626730d56..cc64c8bdb62 100644 --- a/src/components/script/dom/node.rs +++ b/src/components/script/dom/node.rs @@ -1346,9 +1346,9 @@ impl Node { Ok(()) } - pub fn InsertBefore(&self, node: AbstractNode, child: Option) + pub fn InsertBefore(&self, abstract_self: AbstractNode, node: AbstractNode, child: Option) -> Fallible { - Node::pre_insert(node, node, child) + Node::pre_insert(node, abstract_self, child) } pub fn wait_until_safe_to_modify_dom(&self) {