Really fix #3738 by only processing iframe src attributes during parsing.

This commit is contained in:
Josh Matthews 2014-10-23 17:25:39 -04:00
parent 012a80cc18
commit 225ec3ed4e
8 changed files with 20 additions and 7 deletions

View file

@ -121,7 +121,7 @@ impl<'a> HTMLIFrameElementHelpers for JSRef<'a, HTMLIFrameElement> {
}));
let doc = document_from_node(self).root();
if doc.ReadyState() != DocumentReadyStateValues::Complete {
if doc.ReadyState() == DocumentReadyStateValues::Loading {
// https://github.com/servo/servo/issues/3738
// We can't handle dynamic frame tree changes in the compositor right now.
let ConstellationChan(ref chan) = page.constellation_chan;

View file

@ -0,0 +1,2 @@
<iframe id="whee"></iframe>
<script>document.getElementById('whee').src = "http://google.com"</script>

View file

@ -1,3 +1,5 @@
[open-url-javascript-window-2.htm]
type: testharness
expected: CRASH
expected: TIMEOUT
[XMLHttpRequest: open() - resolving URLs (javascript: ]
expected: TIMEOUT

View file

@ -1,3 +1,5 @@
[open-url-javascript-window.htm]
type: testharness
expected: CRASH
expected: TIMEOUT
[XMLHttpRequest: open() - resolving URLs (javascript: ]
expected: TIMEOUT

View file

@ -1,3 +1,3 @@
[Document-createElement-namespace.html]
type: testharness
expected: CRASH
expected: TIMEOUT

View file

@ -1,3 +1,9 @@
[load-text-plain.html]
type: testharness
expected: CRASH
expected: TIMEOUT
[Checking document metadata for text file]
expected: NOTRUN
[Checking DOM for text file]
expected: NOTRUN
[Checking contents for text file]
expected: NOTRUN

View file

@ -1,3 +1,3 @@
[document-base-url.html]
type: testharness
expected: CRASH
expected: TIMEOUT

View file

@ -1,3 +1,4 @@
[039.html]
type: testharness
expected: CRASH
[ scheduler: IFRAMEs added with DOM]
expected: FAIL