Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #9010 - Ms2ger:warnings, r=jdm

Browse source 
Silence warnings in htmlformelement.rs.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9010)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-12-18 15:16:32 +05:30
commit 22e1ccae37
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/htmlformelement.rs
View file

@ -9,7 +9,6 @@ use dom::bindings::codegen::Bindings::HTMLButtonElementBinding::HTMLButtonElemen
use dom::bindings::codegen::Bindings::HTMLFormElementBinding; use dom::bindings::codegen::Bindings::HTMLFormElementBinding;
use dom::bindings::codegen::Bindings::HTMLFormElementBinding::HTMLFormElementMethods; use dom::bindings::codegen::Bindings::HTMLFormElementBinding::HTMLFormElementMethods;
use dom::bindings::codegen::Bindings::HTMLInputElementBinding::HTMLInputElementMethods; use dom::bindings::codegen::Bindings::HTMLInputElementBinding::HTMLInputElementMethods;
use dom::bindings::codegen::Bindings::HTMLTextAreaElementBinding::HTMLTextAreaElementMethods;
use dom::bindings::conversions::DerivedFrom; use dom::bindings::conversions::DerivedFrom;
use dom::bindings::global::GlobalRef; use dom::bindings::global::GlobalRef;
use dom::bindings::inheritance::{Castable, ElementTypeId, HTMLElementTypeId, NodeTypeId}; use dom::bindings::inheritance::{Castable, ElementTypeId, HTMLElementTypeId, NodeTypeId};
@ -249,7 +248,7 @@ impl HTMLFormElement {
/// https://html.spec.whatwg.org/multipage/#interactively-validate-the-constraints /// https://html.spec.whatwg.org/multipage/#interactively-validate-the-constraints
fn interactive_validation(&self) -> Result<(), ()> { fn interactive_validation(&self) -> Result<(), ()> {
// Step 1-3 // Step 1-3
let unhandled_invalid_controls = match self.static_validation() { let _unhandled_invalid_controls = match self.static_validation() {
Ok(()) => return Ok(()), Ok(()) => return Ok(()),
Err(err) => err Err(err) => err
}; };
@ -267,7 +266,7 @@ impl HTMLFormElement {
// form, refactor this when html5ever's form owner PR lands // form, refactor this when html5ever's form owner PR lands
// Step 1-3 // Step 1-3
let invalid_controls = node.traverse_preorder().filter_map(|field| { let invalid_controls = node.traverse_preorder().filter_map(|field| {
if let Some(el) = field.downcast::<Element>() { if let Some(_el) = field.downcast::<Element>() {
None // Remove this line if you decide to refactor None // Remove this line if you decide to refactor
// XXXKiChjang: Form control elements should each have a candidate_for_validation // XXXKiChjang: Form control elements should each have a candidate_for_validation
@ -564,7 +563,7 @@ impl<'a> FormSubmitter<'a> {
} }
} }
fn no_validate(&self, form_owner: &HTMLFormElement) -> bool { fn no_validate(&self, _form_owner: &HTMLFormElement) -> bool {
match *self { match *self {
FormSubmitter::FormElement(form) => form.NoValidate(), FormSubmitter::FormElement(form) => form.NoValidate(),
FormSubmitter::InputElement(input_element) => { FormSubmitter::InputElement(input_element) => {