Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-17 10:28:22 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add signal to request (#39290)

Browse source 
The signal taken from the requestinit is now passed into
the request object with the relevant steps. I added all
spec comments to this method, as I had trouble figuring
out which steps I had to add.

This required implementing the algorithm to create
dependent signals, which is used in the `any()` method.
So that's now implemented as well.

All of that required the machinery to have dependent and
source signals on an AbortSignal. It uses an IndexSet
as the spec requires it to be an ordered set.

Part of #34866

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
This commit is contained in:
Tim van der Lippe 2025-09-16 22:41:12 +02:00 • committed by GitHub
parent 1898a740a8
commit 22fbb3458b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 278 additions and 266 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/wpt/meta/fetch/api/abort/general.any.js.ini vendored
View file

@ -12,9 +12,6 @@
[Aborting rejects with AbortError - no-cors]
expected: FAIL
[Request objects have a signal property]
expected: FAIL
[Signal on request object]
expected: FAIL
@ -96,12 +93,6 @@
[Readable stream synchronously cancels with AbortError if aborted before reading]
expected: NOTRUN
[Signal state is cloned]
expected: FAIL
[Clone aborts with original controller]
expected: FAIL
[Aborting rejects with abort reason]
expected: FAIL
@ -123,9 +114,6 @@
[Aborting rejects with AbortError - no-cors]
expected: FAIL
[Request objects have a signal property]
expected: FAIL
[Signal on request object]
expected: FAIL
@ -207,12 +195,6 @@
[Readable stream synchronously cancels with AbortError if aborted before reading]
expected: NOTRUN
[Signal state is cloned]
expected: FAIL
[Clone aborts with original controller]
expected: FAIL
[Aborting rejects with abort reason]
expected: FAIL

12
tests/wpt/meta/fetch/api/idlharness.any.js.ini vendored
View file

@ -8,9 +8,6 @@
[Request interface: attribute isHistoryNavigation]
expected: FAIL
[Request interface: attribute signal]
expected: FAIL
[Request interface: attribute duplex]
expected: FAIL
@ -23,9 +20,6 @@
[Request interface: new Request('about:blank') must inherit property "isHistoryNavigation" with the proper type]
expected: FAIL
[Request interface: new Request('about:blank') must inherit property "signal" with the proper type]
expected: FAIL
[Request interface: new Request('about:blank') must inherit property "duplex" with the proper type]
expected: FAIL
@ -43,9 +37,6 @@
[Request interface: attribute isHistoryNavigation]
expected: FAIL
[Request interface: attribute signal]
expected: FAIL
[Request interface: attribute duplex]
expected: FAIL
@ -58,9 +49,6 @@
[Request interface: new Request('about:blank') must inherit property "isHistoryNavigation" with the proper type]
expected: FAIL
[Request interface: new Request('about:blank') must inherit property "signal" with the proper type]
expected: FAIL
[Request interface: new Request('about:blank') must inherit property "duplex" with the proper type]
expected: FAIL