Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #29911 - mrobinson:static-absolute-with-static-fixed-child, r=Loirooriol

Browse source 
Fix positioning of statically positioned fixed child of absolutes

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2023-06-25 22:12:45 +02:00 • committed by GitHub
commit 234d507234
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 37 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/layout_2020/positioned.rs
View file

@ -626,8 +626,19 @@ impl HoistedAbsolutelyPositionedBox {
)
};
positioning_context.layout_collected_children(layout_context, &mut new_fragment);
// Any hoisted boxes that remain in this positioning context are going to be hoisted
// up above this absolutely positioned box. These will necessarily be fixed position
// elements, because absolutely positioned elements form containing blocks for all
// other elements. If any of them have a static start position though, we need to
// adjust it to account for the start corner of this absolute.
positioning_context.adjust_static_position_of_hoisted_fragments_with_offset(
&new_fragment.content_rect.start_corner,
);
for_nearest_containing_block_for_all_descendants
.extend(positioning_context.for_nearest_containing_block_for_all_descendants);
new_fragment
}
}

13
tests/wpt/meta/MANIFEST.json
View file

@ -31663,6 +31663,19 @@
{}
]
],
"static-fixed-inside-abspos.html": [
"e3c3aa450d42505557b1f3eefd0aee8ea63fa4d6",
[
null,
[
[
"/css/reference/ref-filled-green-100px-square.xht",
"=="
]
],
{}
]
],
"static-inside-inline-block.html": [
"327e8e6dacdeabb4d2d57ab700d80f966ccde76b",
[

2
tests/wpt/meta/css/css-position/hypothetical-dynamic-change-001.html.ini
View file

@ -1,2 +0,0 @@
[hypothetical-dynamic-change-001.html]
expected: FAIL

2
tests/wpt/meta/css/css-position/hypothetical-dynamic-change-002.html.ini
View file

@ -1,2 +0,0 @@
[hypothetical-dynamic-change-002.html]
expected: FAIL

2
tests/wpt/meta/css/css-position/position-fixed-scroll-nested-fixed.html.ini
View file

@ -1,2 +0,0 @@
[position-fixed-scroll-nested-fixed.html]
expected: FAIL

13
tests/wpt/web-platform-tests/css/CSS2/abspos/static-fixed-inside-abspos.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<title>Static position fixed inside static position absolute</title>
<link rel="author" title="Martin Robinson" href="mrobinson@igalia.com">
<link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#abs-non-replaced-width" title="10.3.7 Absolutely positioned, non-replaced elements">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="display: absolute; width: 100px; height: 100px; background: green;">
<div style="position: absolute; width: 50px; height: 50px; margin-left: 50px; margin-top: 50px; background: red;">
<div style="position: fixed; width: 50px; height: 50px; background: green;"></div>
</div>
</div>