Auto merge of #18533 - servo:TASKS, r=SimonSapin

Rename Runnable to Task and other improvements

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18533)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-09-18 14:42:50 -05:00 committed by GitHub
commit 23701f8659
43 changed files with 916 additions and 1090 deletions

View file

@ -87,7 +87,7 @@ use js::jsval::JSVal;
use net_traits::request::CorsSettings;
use ref_filter_map::ref_filter_map;
use script_layout_interface::message::ReflowQueryType;
use script_thread::{Runnable, ScriptThread};
use script_thread::ScriptThread;
use selectors::attr::{AttrSelectorOperation, NamespaceConstraint, CaseSensitivity};
use selectors::matching::{ElementSelectorFlags, LocalMatchingContext, MatchingContext, MatchingMode};
use selectors::matching::{HAS_EDGE_CHILD_SELECTOR, HAS_SLOW_SELECTOR, HAS_SLOW_SELECTOR_LATER_SIBLINGS};
@ -119,6 +119,7 @@ use style::thread_state;
use style::values::{CSSFloat, Either};
use style::values::{specified, computed};
use stylesheet_loader::StylesheetOwner;
use task::Task;
// TODO: Update focus state when the top-level browsing context gains or loses system focus,
// and when the element enters or leaves a browsing context container.
@ -3046,9 +3047,9 @@ impl ElementPerformFullscreenEnter {
}
}
impl Runnable for ElementPerformFullscreenEnter {
impl Task for ElementPerformFullscreenEnter {
#[allow(unrooted_must_root)]
fn handler(self: Box<ElementPerformFullscreenEnter>) {
fn run(self: Box<Self>) {
let element = self.element.root();
let document = document_from_node(element.r());
@ -3099,9 +3100,9 @@ impl ElementPerformFullscreenExit {
}
}
impl Runnable for ElementPerformFullscreenExit {
impl Task for ElementPerformFullscreenExit {
#[allow(unrooted_must_root)]
fn handler(self: Box<ElementPerformFullscreenExit>) {
fn run(self: Box<Self>) {
let element = self.element.root();
let document = document_from_node(element.r());
// TODO Step 9.1-5