Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 05:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Always request new XR frames

Browse source
This commit is contained in:
Manish Goregaokar 2019-10-15 11:20:39 -07:00
parent 5e098e3a2a
commit 24bfca9b71
1 changed files with 11 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

30
components/script/dom/xrsession.rs
View file

@ -157,6 +157,16 @@ impl XRSession {
); );
}), }),
); );
self.request_new_xr_frame();
}
/// Requests a new https://immersive-web.github.io/webxr/#xr-animation-frame
///
/// This happens regardless of the presense of rAF callbacks
fn request_new_xr_frame(&self) {
let sender = self.raf_sender.borrow().clone().unwrap();
self.session.borrow_mut().request_animation_frame(sender);
} }
fn attach_event_handler(&self) { fn attach_event_handler(&self) {
@ -319,6 +329,7 @@ impl XRSession {
frame.set_active(false); frame.set_active(false);
self.session.borrow_mut().render_animation_frame(); self.session.borrow_mut().render_animation_frame();
self.request_new_xr_frame();
// If the canvas element is attached to the DOM, it is now dirty, // If the canvas element is attached to the DOM, it is now dirty,
// and we need to trigger a reflow. // and we need to trigger a reflow.
@ -396,9 +407,6 @@ impl XRSessionMethods for XRSession {
/// https://immersive-web.github.io/webxr/#dom-xrsession-requestanimationframe /// https://immersive-web.github.io/webxr/#dom-xrsession-requestanimationframe
fn RequestAnimationFrame(&self, callback: Rc<XRFrameRequestCallback>) -> i32 { fn RequestAnimationFrame(&self, callback: Rc<XRFrameRequestCallback>) -> i32 {
// We only need to send a message once, until a raf callback executes.
let should_send = self.raf_callback_list.borrow().is_empty();
// queue up RAF callback, obtain ID // queue up RAF callback, obtain ID
let raf_id = self.next_raf_id.get(); let raf_id = self.next_raf_id.get();
self.next_raf_id.set(raf_id + 1); self.next_raf_id.set(raf_id + 1);
@ -406,22 +414,6 @@ impl XRSessionMethods for XRSession {
.borrow_mut() .borrow_mut()
.push((raf_id, Some(callback))); .push((raf_id, Some(callback)));
if should_send {
// If our callback list is empty, it either means this is the first request,
// or raf_callback executed, in which case we should
// send a message to request an animation frame.
//
// This prevents multiple messages being sent for a single call to raf_callback,
// and multiple message are unnecessary,
// since one call will already deal with multiple potentially enqueued callbacks.
//
// Allowing multiple messages could keep the main-thread,
// where the session thread might be running, looping on incoming messages.
let sender = self.raf_sender.borrow().clone().unwrap();
self.session.borrow_mut().request_animation_frame(sender);
}
raf_id raf_id
} }