Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

removed duplicate entries from sourcedNamesVec for step 7 of SupportedPropertyNames

Browse source
This commit is contained in:
Anshul Jethvani 2019-12-16 01:41:59 -05:00
parent 4682d9231d
commit 254bbc3b8c
1 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/script/dom/htmlformelement.rs
View file

@ -274,7 +274,8 @@ impl HTMLFormElementMethods for HTMLFormElement {
.downcast::<HTMLElement>() .downcast::<HTMLElement>()
.map_or(false, |c| c.is_listed_element()) .map_or(false, |c| c.is_listed_element())
{ {
if child.has_attribute(&local_name!("id")) || if (child.has_attribute(&local_name!("id")) &&
child.get_string_attribute(&local_name!("id")) == name) ||
(child.has_attribute(&local_name!("name")) && (child.has_attribute(&local_name!("name")) &&
child.get_string_attribute(&local_name!("name")) == name) child.get_string_attribute(&local_name!("name")) == name)
{ {
@ -286,7 +287,8 @@ impl HTMLFormElementMethods for HTMLFormElement {
if candidates.len() == 0 { if candidates.len() == 0 {
for child in controls.iter() { for child in controls.iter() {
if child.is::<HTMLImageElement>() { if child.is::<HTMLImageElement>() {
if child.has_attribute(&local_name!("id")) || if (child.has_attribute(&local_name!("id")) &&
child.get_string_attribute(&local_name!("id")) == name) ||
(child.has_attribute(&local_name!("name")) && (child.has_attribute(&local_name!("name")) &&
child.get_string_attribute(&local_name!("name")) == name) child.get_string_attribute(&local_name!("name")) == name)
{ {
@ -459,13 +461,16 @@ impl HTMLFormElementMethods for HTMLFormElement {
// Step 6 // Step 6
sourcedNamesVec.retain(|sn| !sn.name.to_string().is_empty()); sourcedNamesVec.retain(|sn| !sn.name.to_string().is_empty());
// Step 7 // Step 7-8
// Q1. Unable to clearly understand. It seems to contradict with step 4.
// Step 8
let mut namesVec: Vec<DOMString> = Vec::new(); let mut namesVec: Vec<DOMString> = Vec::new();
for elem in sourcedNamesVec.iter() { for elem in sourcedNamesVec.iter() {
namesVec.push(elem.name.clone()); if namesVec
.iter()
.find(|name| name.to_string() == elem.name.to_string())
.is_none()
{
namesVec.push(elem.name.clone());
}
} }
return namesVec; return namesVec;