address review comments

This commit is contained in:
Manish Goregaokar 2015-06-02 07:30:37 +05:30
parent 13b4bcfbb7
commit 2551cce51e

View file

@ -22,7 +22,7 @@ use syntax::ext::build::AstBuilder;
use syntax::ext::deriving::generic::*; use syntax::ext::deriving::generic::*;
pub fn expand_heap_size(cx: &mut ExtCtxt, span: Span, mitem: &MetaItem, pub fn expand_heap_size(cx: &mut ExtCtxt, span: Span, mitem: &MetaItem,
item: Annotatable, push: &mut FnMut(Annotatable)) { item: Annotatable, push: &mut FnMut(Annotatable)) {
let trait_def = TraitDef { let trait_def = TraitDef {
span: span, span: span,
attributes: Vec::new(), attributes: Vec::new(),
@ -61,7 +61,7 @@ fn heap_size_substructure(cx: &mut ExtCtxt, trait_span: Span, substr: &Substruct
MetaNameValue(..) => (), MetaNameValue(..) => (),
_ => cx.span_err(a.span, "#[ignore_heap_size_of] \ _ => cx.span_err(a.span, "#[ignore_heap_size_of] \
should have an explanation, \ should have an explanation, \
e.g. #[ignore_heap_size_of = \"foo\"]") e.g. #[ignore_heap_size_of = \"\"]")
} }
true true
} else { } else {