Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Check for adjacent duplicates when accumulating revalidation selectors.

Browse source 
MozReview-Commit-ID: 4C8L5u1S1sL
This commit is contained in:
Bobby Holley 2017-04-26 17:25:43 -07:00
parent 7e69cf82be
commit 25832b962f
1 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/style/stylist.rs
View file

@ -336,7 +336,20 @@ impl Stylist {
self.dependencies.note_selector(selector);
if needs_revalidation(selector) {
self.selectors_for_cache_revalidation.push(selector.inner.slice_to_first_ancestor_combinator());
// For revalidation, we can skip everything left of the first ancestor
// combinator.
let revalidation_sel = selector.inner.slice_to_first_ancestor_combinator();
// Because of the slicing we do above, we can often end up with
// adjacent duplicate selectors when we have selectors like
// body > foo, td > foo, th > foo, etc. Doing a check for
// adjacent duplicates here reduces the number of revalidation
// selectors for Gecko's UA sheet by 30%.
let duplicate = self.selectors_for_cache_revalidation.last()
.map_or(false, |x| x.complex == revalidation_sel.complex);
if !duplicate {
self.selectors_for_cache_revalidation.push(revalidation_sel);
}
}
}
}