mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters. Returning raw JSVal values makes it easier to create GC hazards in code that calls these methods. Accepting a MutableHandle argument instead ensures that the values are rooted by the caller. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Update mozjs. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Fix clippy warnings. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
537958a3cc
commit
25a0764a37
38 changed files with 763 additions and 515 deletions
|
@ -3,7 +3,7 @@
|
|||
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
||||
|
||||
use dom_struct::dom_struct;
|
||||
use js::jsval::JSVal;
|
||||
use js::rust::MutableHandleValue;
|
||||
|
||||
use crate::dom::bindings::codegen::Bindings::ResizeObserverEntryBinding::ResizeObserverEntryMethods;
|
||||
use crate::dom::bindings::reflector::{reflect_dom_object_with_proto, Reflector};
|
||||
|
@ -90,32 +90,32 @@ impl ResizeObserverEntryMethods for ResizeObserverEntry {
|
|||
}
|
||||
|
||||
/// <https://drafts.csswg.org/resize-observer/#dom-resizeobserverentry-borderboxsize>
|
||||
fn BorderBoxSize(&self, cx: SafeJSContext) -> JSVal {
|
||||
fn BorderBoxSize(&self, cx: SafeJSContext, retval: MutableHandleValue) {
|
||||
let sizes: Vec<DomRoot<ResizeObserverSize>> = self
|
||||
.border_box_size
|
||||
.iter()
|
||||
.map(|size| DomRoot::from_ref(&**size))
|
||||
.collect();
|
||||
to_frozen_array(sizes.as_slice(), cx)
|
||||
to_frozen_array(sizes.as_slice(), cx, retval)
|
||||
}
|
||||
|
||||
/// <https://drafts.csswg.org/resize-observer/#dom-resizeobserverentry-contentboxsize>
|
||||
fn ContentBoxSize(&self, cx: SafeJSContext) -> JSVal {
|
||||
fn ContentBoxSize(&self, cx: SafeJSContext, retval: MutableHandleValue) {
|
||||
let sizes: Vec<DomRoot<ResizeObserverSize>> = self
|
||||
.content_box_size
|
||||
.iter()
|
||||
.map(|size| DomRoot::from_ref(&**size))
|
||||
.collect();
|
||||
to_frozen_array(sizes.as_slice(), cx)
|
||||
to_frozen_array(sizes.as_slice(), cx, retval);
|
||||
}
|
||||
|
||||
/// <https://drafts.csswg.org/resize-observer/#dom-resizeobserverentry-devicepixelcontentboxsize>
|
||||
fn DevicePixelContentBoxSize(&self, cx: SafeJSContext) -> JSVal {
|
||||
fn DevicePixelContentBoxSize(&self, cx: SafeJSContext, retval: MutableHandleValue) {
|
||||
let sizes: Vec<DomRoot<ResizeObserverSize>> = self
|
||||
.device_pixel_content_box_size
|
||||
.iter()
|
||||
.map(|size| DomRoot::from_ref(&**size))
|
||||
.collect();
|
||||
to_frozen_array(sizes.as_slice(), cx)
|
||||
to_frozen_array(sizes.as_slice(), cx, retval);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue