Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use out parameter for generated methods returning JSVal (#34087)

Browse source 
* Make generated bindings that return a WebIDL `any` value use out parameters.

Returning raw JSVal values makes it easier to create GC hazards in code
that calls these methods. Accepting a MutableHandle argument instead
ensures that the values are rooted by the caller.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Update mozjs.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix clippy warnings.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-11-05 03:29:08 -05:00 • committed by GitHub
parent 537958a3cc
commit 25a0764a37
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
38 changed files with 763 additions and 515 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/xrinputsourceschangeevent.rs
View file

@ -5,7 +5,7 @@
use dom_struct::dom_struct;
use js::jsapi::Heap;
use js::jsval::JSVal;
use js::rust::HandleObject;
use js::rust::{HandleObject, MutableHandleValue};
use servo_atoms::Atom;
use crate::dom::bindings::codegen::Bindings::EventBinding::Event_Binding::EventMethods;
@ -87,8 +87,11 @@ impl XRInputSourcesChangeEvent {
}
let _ac = enter_realm(global);
let cx = GlobalScope::get_cx();
changeevent.added.set(to_frozen_array(added, cx));
changeevent.removed.set(to_frozen_array(removed, cx));
rooted!(in(*cx) let mut frozen_val: JSVal);
to_frozen_array(added, cx, frozen_val.handle_mut());
changeevent.added.set(*frozen_val);
to_frozen_array(removed, cx, frozen_val.handle_mut());
changeevent.removed.set(*frozen_val);
changeevent
}
}
@ -121,13 +124,13 @@ impl XRInputSourcesChangeEventMethods for XRInputSourcesChangeEvent {
}
// https://immersive-web.github.io/webxr/#dom-xrinputsourceschangeevent-added
fn Added(&self, _cx: JSContext) -> JSVal {
self.added.get()
fn Added(&self, _cx: JSContext, mut retval: MutableHandleValue) {
retval.set(self.added.get())
}
// https://immersive-web.github.io/webxr/#dom-xrinputsourceschangeevent-removed
fn Removed(&self, _cx: JSContext) -> JSVal {
self.removed.get()
fn Removed(&self, _cx: JSContext, mut retval: MutableHandleValue) {
retval.set(self.removed.get())
}
// https://dom.spec.whatwg.org/#dom-event-istrusted