mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters. Returning raw JSVal values makes it easier to create GC hazards in code that calls these methods. Accepting a MutableHandle argument instead ensures that the values are rooted by the caller. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Update mozjs. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Fix clippy warnings. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
537958a3cc
commit
25a0764a37
38 changed files with 763 additions and 515 deletions
|
@ -7,6 +7,7 @@ use euclid::RigidTransform3D;
|
|||
use js::conversions::ToJSValConvertible;
|
||||
use js::jsapi::Heap;
|
||||
use js::jsval::{JSVal, UndefinedValue};
|
||||
use js::rust::MutableHandleValue;
|
||||
use webxr_api::{Viewer, ViewerPose, Views};
|
||||
|
||||
use crate::dom::bindings::codegen::Bindings::XRViewBinding::XREye;
|
||||
|
@ -189,7 +190,7 @@ impl XRViewerPose {
|
|||
|
||||
impl XRViewerPoseMethods for XRViewerPose {
|
||||
/// <https://immersive-web.github.io/webxr/#dom-xrviewerpose-views>
|
||||
fn Views(&self, _cx: JSContext) -> JSVal {
|
||||
self.views.get()
|
||||
fn Views(&self, _cx: JSContext, mut retval: MutableHandleValue) {
|
||||
retval.set(self.views.get())
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue