From 2634ad10de643e9c6ff93bbec4e8941d10b0ce75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Mon, 22 May 2023 10:05:08 +0200 Subject: [PATCH] style: Blockify outside markers at used value time rather than at computed value time Trusting the display value in style_adjuster is wrong, as some elements force a given kind of frame (like
). Differential Revision: https://phabricator.services.mozilla.com/D119609 --- components/style/style_adjuster.rs | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/components/style/style_adjuster.rs b/components/style/style_adjuster.rs index e9c82f60d0e..5e66e91e894 100644 --- a/components/style/style_adjuster.rs +++ b/components/style/style_adjuster.rs @@ -232,9 +232,6 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { where E: TElement, { - #[cfg(any(feature = "servo-layout-2013", feature = "gecko"))] - use crate::computed_values::list_style_position::T as ListStylePosition; - let mut blockify = false; macro_rules! blockify_if { ($if_what:expr) => { @@ -254,16 +251,6 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { blockify_if!(self.style.is_floating()); blockify_if!(self.style.is_absolutely_positioned()); - #[cfg(any(feature = "servo-layout-2013", feature = "gecko"))] - blockify_if!( - self.style.pseudo.map_or(false, |p| p.is_marker()) && - self.style.get_parent_list().clone_list_style_position() == - ListStylePosition::Outside && - !layout_parent_style - .get_box() - .clone_display() - .is_inline_flow() - ); if !blockify { return;