Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Fix a bunch of warnings in script (#32680)

Browse source 
This is just a portion of the errors that are remaining to be fixed.
This commit is contained in:
Martin Robinson 2024-07-04 13:40:23 +02:00 • committed by GitHub
parent 93fdb8263d
commit 26624a109f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
27 changed files with 150 additions and 113 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/bindings/xmlname.rs
View file

@ -13,7 +13,7 @@ use crate::dom::bindings::str::DOMString;
pub fn validate_qualified_name(qualified_name: &str) -> ErrorResult {
// Step 2.
match xml_name_type(qualified_name) {
XMLName::InvalidXMLName => Err(Error::InvalidCharacter),
XMLName::Invalid => Err(Error::InvalidCharacter),
XMLName::Name => Err(Error::InvalidCharacter), // see whatwg/dom#671
XMLName::QName => Ok(()),
}
@ -83,7 +83,7 @@ pub fn validate_and_extract(
pub enum XMLName {
QName,
Name,
InvalidXMLName,
Invalid,
}
/// Check if an element name is valid. See <http://www.w3.org/TR/xml/#NT-Name>
@ -123,10 +123,10 @@ pub fn xml_name_type(name: &str) -> XMLName {
let mut non_qname_colons = false;
let mut seen_colon = false;
let mut last = match iter.next() {
None => return XMLName::InvalidXMLName,
None => return XMLName::Invalid,
Some(c) => {
if !is_valid_start(c) {
return XMLName::InvalidXMLName;
return XMLName::Invalid;
}
if c == ':' {
non_qname_colons = true;
@ -137,7 +137,7 @@ pub fn xml_name_type(name: &str) -> XMLName {
for c in iter {
if !is_valid_continuation(c) {
return XMLName::InvalidXMLName;
return XMLName::Invalid;
}
if c == ':' {
if seen_colon {