Merge pull request #3461 from mbrubeck/warnings

Fix misc warnings in devtools crates. r=jdm
This commit is contained in:
Matt Brubeck 2014-09-23 13:20:44 -07:00
commit 2886fccb3e
4 changed files with 8 additions and 4 deletions

View file

@ -136,7 +136,7 @@ impl ActorRegistry {
// fails for unknown reasons. // fails for unknown reasons.
/*let actor: &Actor+Send+Sized = *self.actors.find(&name.to_string()).unwrap(); /*let actor: &Actor+Send+Sized = *self.actors.find(&name.to_string()).unwrap();
(actor as &Any).downcast_ref::<T>().unwrap()*/ (actor as &Any).downcast_ref::<T>().unwrap()*/
self.actors.find(&name.to_string()).unwrap().as_ref::<T>().unwrap() self.actors.find(&name.to_string()).unwrap().downcast_ref::<T>().unwrap()
} }
/// Find an actor by registered name /// Find an actor by registered name
@ -162,7 +162,7 @@ impl ActorRegistry {
} }
} }
} }
let mut new_actors = replace(&mut *self.new_actors.borrow_mut(), vec!()); let new_actors = replace(&mut *self.new_actors.borrow_mut(), vec!());
for actor in new_actors.into_iter() { for actor in new_actors.into_iter() {
self.actors.insert(actor.name().to_string(), actor); self.actors.insert(actor.name().to_string(), actor);
} }

View file

@ -157,7 +157,7 @@ impl NodeInfoToProtocol for NodeInfo {
publicId: self.publicId, publicId: self.publicId,
systemId: self.systemId, systemId: self.systemId,
attrs: self.attrs.move_iter().map(|attr| { attrs: self.attrs.into_iter().map(|attr| {
AttrMsg { AttrMsg {
namespace: attr.namespace, namespace: attr.namespace,
name: attr.name, name: attr.name,
@ -262,7 +262,7 @@ impl Actor for WalkerActor {
let msg = ChildrenReply { let msg = ChildrenReply {
hasFirst: true, hasFirst: true,
hasLast: true, hasLast: true,
nodes: children.move_iter().map(|child| { nodes: children.into_iter().map(|child| {
child.encode(registry, true) child.encode(registry, true)
}).collect(), }).collect(),
from: self.name(), from: self.name(),

View file

@ -8,6 +8,8 @@
#![comment = "The Servo Parallel Browser Project"] #![comment = "The Servo Parallel Browser Project"]
#![license = "MPL"] #![license = "MPL"]
#![allow(non_snake_case)]
#![feature(phase)] #![feature(phase)]
#![feature(phase)] #![feature(phase)]

View file

@ -8,6 +8,8 @@
#![comment = "The Servo Parallel Browser Project"] #![comment = "The Servo Parallel Browser Project"]
#![license = "MPL"] #![license = "MPL"]
#![allow(non_snake_case)]
extern crate "msg" as servo_msg; extern crate "msg" as servo_msg;
/// This module contains shared types and messages for use by devtools/script. /// This module contains shared types and messages for use by devtools/script.