Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 23:33:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use std::intrinsics::TypeId

Browse source 
Fix indentation + update comment
This commit is contained in:
Jim Berlage 2014-09-30 21:56:27 -04:00
parent 6358b7d94e
commit 28e29dc32e
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/devtools/actor.rs
View file

@ -4,9 +4,10 @@
/// General actor system infrastructure. /// General actor system infrastructure.
use std::any::{Any, AnyRefExt, AnyMutRefExt}; use std::any::{AnyPrivate, AnyRefExt, AnyMutRefExt};
use std::collections::hashmap::HashMap; use std::collections::hashmap::HashMap;
use std::cell::{Cell, RefCell}; use std::cell::{Cell, RefCell};
use std::intrinsics::TypeId;
use std::io::TcpStream; use std::io::TcpStream;
use std::mem::{transmute, transmute_copy, replace}; use std::mem::{transmute, transmute_copy, replace};
use std::raw::TraitObject; use std::raw::TraitObject;
@ -15,7 +16,7 @@ use serialize::json;
/// A common trait for all devtools actors that encompasses an immutable name /// A common trait for all devtools actors that encompasses an immutable name
/// and the ability to process messages that are directed to particular actors. /// and the ability to process messages that are directed to particular actors.
/// TODO: ensure the name is immutable /// TODO: ensure the name is immutable
pub trait Actor: Any { pub trait Actor: AnyPrivate {
fn handle_message(&self, fn handle_message(&self,
registry: &ActorRegistry, registry: &ActorRegistry,
msg_type: &String, msg_type: &String,
@ -42,14 +43,11 @@ impl<'a> AnyMutRefExt<'a> for &'a mut Actor + 'a {
impl<'a> AnyRefExt<'a> for &'a Actor + 'a { impl<'a> AnyRefExt<'a> for &'a Actor + 'a {
fn is<T: 'static>(self) -> bool { fn is<T: 'static>(self) -> bool {
//FIXME: This implementation is bogus since get_type_id is private now. // This implementation is only needed so long as there's a Rust bug that
// However, this implementation is only needed so long as there's a Rust bug // prevents downcast_ref from giving realistic return values.
// that prevents downcast_ref from giving realistic return values, and this is let t = TypeId::of::<T>();
// ok since we're careful with the types we pull out of the hashmap.
/*let t = TypeId::of::<T>();
let boxed = self.get_type_id(); let boxed = self.get_type_id();
t == boxed*/ t == boxed
true
} }
fn downcast_ref<T: 'static>(self) -> Option<&'a T> { fn downcast_ref<T: 'static>(self) -> Option<&'a T> {