From d6b24682ab83b47be972c68a56ca328483a4d1cf Mon Sep 17 00:00:00 2001 From: Jesse McNelis Date: Mon, 26 May 2025 21:48:43 +1000 Subject: [PATCH] Get href and title of stylesheet when passing html link element Signed-off-by: Jesse McNelis --- components/script/dom/htmllinkelement.rs | 4 ++-- components/script/dom/htmlstyleelement.rs | 4 ++-- ...tylesheet-not-removed-until-next-stylesheet-loads.html.ini | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/components/script/dom/htmllinkelement.rs b/components/script/dom/htmllinkelement.rs index f4e7683cf2a..157c34e1f7f 100644 --- a/components/script/dom/htmllinkelement.rs +++ b/components/script/dom/htmllinkelement.rs @@ -183,8 +183,8 @@ impl HTMLLinkElement { &self.owner_window(), Some(self.upcast::()), "text/css".into(), - None, // todo handle location - None, // todo handle title + get_attr(self.upcast(), &local_name!("href")).map(DOMString::from_string), + get_attr(self.upcast(), &local_name!("title")).map(DOMString::from_string), sheet, false, // is_constructed can_gc, diff --git a/components/script/dom/htmlstyleelement.rs b/components/script/dom/htmlstyleelement.rs index aed08b7bcf6..e77b29dfa68 100644 --- a/components/script/dom/htmlstyleelement.rs +++ b/components/script/dom/htmlstyleelement.rs @@ -167,8 +167,8 @@ impl HTMLStyleElement { &self.owner_window(), Some(self.upcast::()), "text/css".into(), - None, // todo handle location - None, // todo handle title + None, + None, sheet, false, // is_constructed CanGc::note(), diff --git a/tests/wpt/meta/html/semantics/document-metadata/the-link-element/stylesheet-not-removed-until-next-stylesheet-loads.html.ini b/tests/wpt/meta/html/semantics/document-metadata/the-link-element/stylesheet-not-removed-until-next-stylesheet-loads.html.ini index c8af7d1a992..4ea84934721 100644 --- a/tests/wpt/meta/html/semantics/document-metadata/the-link-element/stylesheet-not-removed-until-next-stylesheet-loads.html.ini +++ b/tests/wpt/meta/html/semantics/document-metadata/the-link-element/stylesheet-not-removed-until-next-stylesheet-loads.html.ini @@ -1,3 +1,3 @@ [stylesheet-not-removed-until-next-stylesheet-loads.html] [Check that a style sheet loaded by a is available until its successor is loaded] - expected: FAIL + expected: PASS