Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Modify the checks for upgrade-request algorithm (#35357)

Browse source 
Signed-off-by: Shubham Gupta <shubham13297@gmail.com>
This commit is contained in:
Shubham Gupta 2025-02-07 21:15:06 +08:00 • committed by GitHub
parent 3c1cce825d
commit 2bb720f0f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/net/fetch/methods.rs
View file

@ -921,13 +921,10 @@ fn should_upgrade_request_to_potentially_trustworty(
// request’s header list if any of the following criteria are met: // request’s header list if any of the following criteria are met:
// * request’s URL is not a potentially trustworthy URL // * request’s URL is not a potentially trustworthy URL
// * request’s URL's host is not a preloadable HSTS host // * request’s URL's host is not a preloadable HSTS host
if !request.current_url().is_origin_trustworthy() || if !request.current_url().is_potentially_trustworthy() ||
!context !request.current_url().host_str().is_some_and(|host| {
.state !context.state.hsts_list.read().unwrap().is_host_secure(host)
.hsts_list })
.read()
.unwrap()
.is_host_secure(request.current_url().host_str().unwrap())
{ {
debug!("Appending the Upgrade-Insecure-Requests header to request’s header list"); debug!("Appending the Upgrade-Insecure-Requests header to request’s header list");
request request

2
components/net/tests/http_loader.rs
View file

@ -171,7 +171,6 @@ fn test_check_default_headers_loaded_in_every_request() {
HeaderName::from_static("sec-fetch-user"), HeaderName::from_static("sec-fetch-user"),
HeaderValue::from_static("?1"), HeaderValue::from_static("?1"),
); );
headers.insert("Upgrade-Insecure-Requests", HeaderValue::from_static("1"));
*expected_headers.lock().unwrap() = Some(headers.clone()); *expected_headers.lock().unwrap() = Some(headers.clone());
@ -326,7 +325,6 @@ fn test_request_and_response_data_with_network_messages() {
HeaderName::from_static("sec-fetch-user"), HeaderName::from_static("sec-fetch-user"),
HeaderValue::from_static("?1"), HeaderValue::from_static("?1"),
); );
headers.insert("Upgrade-Insecure-Requests", HeaderValue::from_static("1"));
let httprequest = DevtoolsHttpRequest { let httprequest = DevtoolsHttpRequest {
url: url, url: url,