Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Replace u32 with computed::Integer for computed::TimingFunction.

Browse source 
We make sure the step number is always positive, so using
computed::Integer is safe and can derive ToComputedValue.

Depends on D9311

Differential Revision: https://phabricator.services.mozilla.com/D9845
This commit is contained in:
Boris Chiou 2018-10-26 18:03:31 +00:00 • committed by Emilio Cobos Álvarez
parent a20b6a5166
commit 2bbcb5c633
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
4 changed files with 9 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/style/gecko_bindings/sugar/ns_timing_function.rs
View file

@ -11,7 +11,7 @@ use values::generics::easing::TimingFunction as GenericTimingFunction;
use values::specified::easing::TimingFunction;
impl nsTimingFunction {
fn set_as_step(&mut self, function_type: nsTimingFunction_Type, steps: u32) {
fn set_as_step(&mut self, function_type: nsTimingFunction_Type, steps: i32) {
debug_assert!(
function_type == nsTimingFunction_Type::StepStart ||
function_type == nsTimingFunction_Type::StepEnd,
@ -22,7 +22,7 @@ impl nsTimingFunction {
self.__bindgen_anon_1
.__bindgen_anon_1
.as_mut()
.mSteps = steps;
.mSteps = steps as u32;
}
}
@ -58,11 +58,11 @@ impl From<TimingFunction> for nsTimingFunction {
match function {
GenericTimingFunction::Steps(steps, StepPosition::Start) => {
debug_assert!(steps.value() >= 0);
tf.set_as_step(nsTimingFunction_Type::StepStart, steps.value() as u32);
tf.set_as_step(nsTimingFunction_Type::StepStart, steps.value());
},
GenericTimingFunction::Steps(steps, StepPosition::End) => {
debug_assert!(steps.value() >= 0);
tf.set_as_step(nsTimingFunction_Type::StepEnd, steps.value() as u32);
tf.set_as_step(nsTimingFunction_Type::StepEnd, steps.value());
},
GenericTimingFunction::CubicBezier { x1, y1, x2, y2 } => {
tf.set_as_bezier(
@ -91,7 +91,7 @@ impl From<nsTimingFunction> for ComputedTimingFunction {
.__bindgen_anon_1
.__bindgen_anon_1
.as_ref()
.mSteps
.mSteps as i32
},
StepPosition::Start,
),
@ -101,7 +101,7 @@ impl From<nsTimingFunction> for ComputedTimingFunction {
.__bindgen_anon_1
.__bindgen_anon_1
.as_ref()
.mSteps
.mSteps as i32
},
StepPosition::End,
),