Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

servoshell: Consider both OS decoration width and height when resizing (#37961)

Browse source 
Previously, we only consider OS decoration height. But when testing
#37960, I find that the decoration width is also non-zero.

Testing: Need to wait W3C spec change
https://github.com/web-platform-tests/wpt/pull/53421 related to
webdriver rectangle. When combined with #37960, this can fix at least
`window_resizeTo.html`.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye 2025-07-09 19:35:29 +08:00 • committed by GitHub
parent 36e5825605
commit 2c52efb113
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
ports/servoshell/desktop/headed_window.rs
View file

@ -469,12 +469,15 @@ impl WindowPortsMethods for Window {
} }
fn request_resize(&self, _: &WebView, new_outer_size: DeviceIntSize) -> Option<DeviceIntSize> { fn request_resize(&self, _: &WebView, new_outer_size: DeviceIntSize) -> Option<DeviceIntSize> {
let title_height = let outer_size = self.winit_window.outer_size();
self.winit_window.outer_size().height - self.winit_window.inner_size().height; let inner_size = self.winit_window.inner_size();
let decoration_height = outer_size.height - inner_size.height;
let decoration_width = outer_size.width - inner_size.width;
self.winit_window self.winit_window
.request_inner_size::<PhysicalSize<i32>>(PhysicalSize::new( .request_inner_size::<PhysicalSize<i32>>(PhysicalSize::new(
new_outer_size.width, new_outer_size.width - decoration_width as i32,
new_outer_size.height - title_height as i32, new_outer_size.height - decoration_height as i32,
)) ))
.and_then(|size| { .and_then(|size| {
Some(DeviceIntSize::new( Some(DeviceIntSize::new(